Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not link HoloViews plots where shared_axes=False #784

Merged
merged 4 commits into from
Nov 14, 2019
Merged

Do not link HoloViews plots where shared_axes=False #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aeaa391
Do not link HoloViews plots where shared_axes=False
philippjfr Nov 14, 2019
f8ceb63
Fixed options lookup
philippjfr Nov 14, 2019
f14cfb8
Dropped bokeh dev channel
philippjfr Nov 14, 2019
9e5515f
Fixed shared_axes
philippjfr Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
environment:
global:
CHANS_DEV: "-c pyviz/label/dev -c bokeh/label/dev -c conda-forge"
CHANS_DEV: "-c pyviz/label/dev -c bokeh -c conda-forge"
matrix:
- PY: "3.6"
CONDA: "C:\\Miniconda36-x64"
Expand Down
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ addons:
env:
global:
- PYENV_VERSION=3.7
- CHANS_DEV="-c pyviz/label/dev -c bokeh/label/dev -c conda-forge"
- CHANS_REL="-c pyviz -c conda-forge"
- CHANS_DEV="-c pyviz/label/dev -c bokeh -c conda-forge"
- CHANS_REL="-c pyviz -c bokeh -c conda-forge"
- LABELS_DEV="--label dev"
- LABELS_REL="--label dev --label main"
- PKG_TEST_PYTHON="--test-python=py36"
Expand Down
5 changes: 3 additions & 2 deletions panel/pane/holoviews.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def _update_layout(self):
else:
try:
opts = Store.lookup_options(backend, self.object, 'plot').kwargs
except KeyError:
except:
opts = {}
responsive_modes = ('stretch_width', 'stretch_both', 'scale_width', 'scale_both')
center = self.center
Expand Down Expand Up @@ -520,7 +520,8 @@ def link_axes(root_view, root_model):
if ref not in pane._plots:
continue
plot = pane._plots[ref][0]
if not pane.linked_axes or plot.renderer.backend != 'bokeh':
if (not pane.linked_axes or plot.renderer.backend != 'bokeh'
or not getattr(plot, 'shared_axes', False)):
continue
for p in plot.traverse(specs=[ElementPlot]):
if p.current_frame is None:
Expand Down