New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VTK] Add axes coordinates to VTK view #817
Conversation
"bokehjs": "^1.3.4" | ||
"@types/gl-matrix": "^2.4.5", | ||
"bokehjs": "^1.3.4", | ||
"gl-matrix": "^3.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware that you could actually load dependencies like this yet. What ends up loading the dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose node and the typescript compiler to create the .js
5505b1b
to
27d9e64
Compare
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
==========================================
- Coverage 69.94% 69.77% -0.17%
==========================================
Files 104 104
Lines 10463 10532 +69
==========================================
+ Hits 7318 7349 +31
- Misses 3145 3183 +38
Continue to review full report at Codecov.
|
9395395
to
f4d1a70
Compare
Thanks for the PR! At some point we need to figure out how to test the Vtk code. |
First prototype of axes for VTK panel:
In the same time I restructure typescript code of VTK pane by splitting in smaller files in a repository specific to vtk
TODO:
axes color, grid colorobject
is changed