Add a FileDownload widget #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I now have a use case for this. I have some CSV files that are 6MB. Chrome has a limit of 2MB for base64 encoded urls. So I cannot use that workaround. |
philippjfr
force-pushed
the
file_download
branch
from
3e3000e
to
e93730a
Compare
|
For sure this will prove to be very useful! |
philippjfr
force-pushed
the
file_download
branch
from
9370a4f
to
e4804ff
Compare
Should work fine yes. |
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
==========================================
+ Coverage 87.82% 87.99% +0.16%
==========================================
Files 105 105
Lines 12456 12757 +301
==========================================
+ Hits 10940 11225 +285
- Misses 1516 1532 +16
Continue to review full report at Codecov.
|
|
Very cool! Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
FileDownloadwhich makes it possible to download some data which is set on the backend. By default the data is not transferred until a user clicks on a link which will start the transfer, once the data is transferred the widget will provide a link which actually downloads the data. I still want to improve the visual styling as currently it just uses bare text.