Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for displaying callback errors and stdout in the notebook #977

Merged
merged 6 commits into from Jan 22, 2020

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 22, 2020

This finally allows displaying both errors and stdout output (e.g. print statements) triggered by a callback in the notebook. This should make debugging a whole log easier. Currently this can be configured using pn.config.debug which is also settable using the pn.extension and an environment variable. By default it accumulates all the output but you can also choose to replace the output each time or display no output at all.

Requires pyviz_comms>=0.7.3 to work.

@philippjfr philippjfr added the type: enhancement label Jan 22, 2020
@philippjfr philippjfr force-pushed the log_output branch 2 times, most recently from ffe91f4 to d070832 Compare Jan 22, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 22, 2020

Codecov Report

Merging #977 into master will increase coverage by 0.09%.
The diff coverage is 91.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
+ Coverage   85.74%   85.83%   +0.09%     
==========================================
  Files          98       99       +1     
  Lines       11077    11235     +158     
==========================================
+ Hits         9498     9644     +146     
- Misses       1579     1591      +12
Impacted Files Coverage Δ
setup.py 0% <ø> (ø) ⬆️
panel/tests/test_config.py 100% <100%> (ø)
panel/pane/markup.py 97.05% <100%> (+1.1%) ⬆️
panel/util.py 90.57% <60%> (-1.22%) ⬇️
panel/config.py 53.08% <75%> (+1.11%) ⬆️
panel/io/state.py 93.18% <75%> (-1.95%) ⬇️
panel/viewable.py 81.45% <80%> (-0.08%) ⬇️
panel/tests/conftest.py 96.1% <90.47%> (-2.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfdecb0...7732952. Read the comment docs.

@philippjfr philippjfr merged commit 33ae2e5 into master Jan 22, 2020
4 checks passed
@philippjfr philippjfr added this to the v0.8.0 milestone Jan 22, 2020
@philippjfr philippjfr deleted the log_output branch Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant