Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package installation inside git repo breaks #60

Closed
stober opened this issue Jun 11, 2014 · 7 comments
Closed

Package installation inside git repo breaks #60

stober opened this issue Jun 11, 2014 · 7 comments

Comments

@stober
Copy link

stober commented Jun 11, 2014

Installing param (pip install param) into a virtual environment that is inside a git repository fails with

Exception: Cannot find any git version tags of format v_._

This makes it difficult to install param as part of certain Jenkins CI workflows that make use of git + virtualenv.

@jbednar
Copy link
Member

jbednar commented Jun 11, 2014

| Installing param (pip install param) into a virtual environment that is inside a git repository fails with
| Exception: Cannot find any git version tags of format v_._
| This makes it difficult to install param as part of certain Jenkins CI workflows that make use of git + virtualenv.

Thanks for the report! Chris, I think you should go ahead with what we mentioned about ignoring all errors from version.py, just for cases like this where we don't quite know what environment it might have been placed into.

Jean-Luc, maybe it would be worth version.py catching this error and falling back to the declared version (plus perhaps "-dirty" or "-unknown" as a warning that we were unable to get version info).

The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.

@jbednar
Copy link
Member

jbednar commented Jun 11, 2014

We've got a fix now, thanks to Marco Elver and Jean-Luc Stevens; see #61

Can you please try installing version 786378d using pip's git support, with something like:

pip install git+https://github.com/ioam/param.git@786378da45e414f714ee4ab9f88c6cf89a551fee

@jlstevens
Copy link
Contributor

Hi

I'm not sure it will work just yet - at least if any of our projects is being tested in this environment other than param. The 'reponame' argument needs to be set in the Version object for the other projects.

I'll fix this now.

@stober
Copy link
Author

stober commented Jun 12, 2014

I think to test the fix, I need to install from a source distribution, not via pip's git support.

@jbednar
Copy link
Member

jbednar commented Jun 12, 2014

Ah. We were hoping that you would test it so that we could make a new release confidently, but I guess we'll have to wing it and cross our fingers! We'll let you know when 1.2.1 is ready.

The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.

@jbednar
Copy link
Member

jbednar commented Jun 14, 2014

Ok, 1.2.1 is released and should fix this problem -- please reopen this issue if not!

@jbednar jbednar closed this as completed Jun 14, 2014
@stober
Copy link
Author

stober commented Jun 15, 2014

This is fixed for me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants