Provide Version fix when project is copied to foreign GIT repository #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement fix for Version to not cause Exception when the project's source code is copied to a foreign GIT repository. The fix is to specify an optional project-name, passed to Version. If a name is provided, the code obtaining version information from GIT first tries to verify we are in the correct GIT repository. A simple heuristic was implemented, which checks the output of 'git remote -v' for the name of the project.
|
|
||
| if proc.returncode != 0: | ||
| raise Exception(proc.returncode, error) | ||
| return output |
There was a problem hiding this comment.
Isn't _git_cmd() actually a reasonably general wrapper for calling a subprocess to get output and catch errors? If so, shouldn't it move out of git_fetch and into a regular method named something like run_cmd()? That way the git-specific code would be much shorter and easier to read, and it would be clearer how to edit the file to support other version control systems.
|
Thanks for contributing this fix. It seems slightly awkward, having to fill in the project name, but I don't see any obvious better solution, and at least that's something that will almost never need editing. So this can be merged once the minor issues above are addressed, unless someone has thought of a better approach... |
jbednar
pushed a commit
that referenced
this pull request
Jun 11, 2014
Provide Version fix when project is copied to foreign Git repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement fix for Version to not cause Exception when the project's
source code is copied to a foreign GIT repository.
The fix is to specify an optional project-name, passed to Version. If a
name is provided, the code obtaining version information from GIT first
tries to verify we are in the correct GIT repository. A simple heuristic
was implemented, which checks the output of 'git remote -v' for the name
of the project.