Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nose with pytest #509

Merged
merged 11 commits into from
Aug 17, 2021
Merged

Replace nose with pytest #509

merged 11 commits into from
Aug 17, 2021

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jul 8, 2021

In line with what was done partially in #423, the goal of this PR is to replace nose by pytest:

  • Minimal changes required to switch to pytest and get the CI green
  • Fix coverage

When this is done, some optional tasks could be tackled such as fixing the warnings already spotted in #423, switching to fixtures when relevant...

@maximlt maximlt marked this pull request as draft July 8, 2021 23:24
@jbednar
Copy link
Member

jbednar commented Jul 8, 2021

Thanks! If you can see a place in the new docs to put information about running the tests, it would be good to capture and communicate that to our (power) users. Could be worth having in a HoloViz developer's guide, as I believe the instructions will now be the same across most of our projects.

@maximlt
Copy link
Member Author

maximlt commented Jul 9, 2021

Yes the new docs could have a Developers page. Do you use pyctdev to develop param? (I haven't used it here)

@jbednar
Copy link
Member

jbednar commented Jul 9, 2021

Param was written long before pyctdev or any of the other HoloViz projects. I recently briefly attempted to move Param to use pyctdev (https://github.com/holoviz/param/pull/502/files), but reverted those changes as there were clearly a whole set of related changes that would need to be made for it to work. Making Param more consistent with the rest of the HoloViz projects using pyctdev would be great, if someone could do that.

@maximlt
Copy link
Member Author

maximlt commented Jul 12, 2021

coverage reporting with coveralls seems to be working again.

@maximlt maximlt marked this pull request as ready for review July 12, 2021 00:06
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants