Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the coverage report uploaded to codecov #709

Merged
merged 3 commits into from Mar 12, 2023
Merged

Fix the coverage report uploaded to codecov #709

merged 3 commits into from Mar 12, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Mar 12, 2023

Found out that because of a bug or user error the XML report produced by pytest-cov included the report of only one __init__.py file instead of two, coming from Param and Numbergen. It happened to report the one of Numbergen only. This PR runs coverage directly which when it builds the XML coverage report does so in a nested way, including the two __init__.py files.

@maximlt maximlt merged commit 6d91ba2 into main Mar 12, 2023
23 checks passed
@maximlt maximlt deleted the fix_coverage branch March 12, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant