Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests #717

Merged
merged 2 commits into from Mar 16, 2023
Merged

Add more tests #717

merged 2 commits into from Mar 16, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Mar 15, 2023

Another one in the series of adding more tests:

  • In a previous PR I added a few tests marked with xfail, anticipating new behavior obtained with the sentinel PR. Instead in this PR I have inverted them, they all pass now on the main branch, which means that the sentinel PR will have to update them, making it easier for reviewers to understand the changed behavior
  • Add more tests on metadata inheritance. They are really there to capture the current behavior and catch changes that may happen in future PRs.

@maximlt maximlt merged commit a85f8b1 into main Mar 16, 2023
18 checks passed
@maximlt maximlt deleted the more_tests branch March 16, 2023 00:52
@maximlt maximlt mentioned this pull request Mar 17, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@maximlt