New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set class attributes during initialization and don't warn when setting non-Param class attributes #729
Conversation
Oh wait, need to resolve conflicts... |
Is |
Maybe a custom one? That sets it apart from normal Python behavior? |
I agree. |
I like it. I just ran this PR across the holoviz ecosystem and got two failing tests related to this change:
This does not necessarily mean these changes are wrong, but some tests need to be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the correct change, thanks!
Great thanks! Merging. |
Fixes #174
TypeError
(breaking change)