Refactor __init__.py
, mostly by moving Parameters to parameters.py
(take 2)
#853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #648
Supersedes #852
This is also adding
__all__
to the__init__.py
.When you start to touch so many lines it's tempting to do some formatting and even more refactoring, styling, imports sorting, etc.. I've decided to stick to address the limitations exposed in the issue; this can be done later.
I think Github supports ignoring specific commits on blame, I'll enable that once this is merged.
Per Jim's comment in #852 (comment)
I have used
git mv __init__.py parameters.py
in this PR (had never used it!) which can only helpgit
. Now we usually squash commits when merging to main and I don't know to which extent that will confusegit blame
. I guess the next step for me is to try that locally.