Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add “tables” to the tests-deser extra #880

Merged
merged 3 commits into from Nov 6, 2023

Conversation

musicinmybrain
Copy link
Contributor

Enables one additional test.

try:
import tables as hdf5
except:
hdf5 = None

hdf5_skip = skipIf(hdf5 is None, "pytables is not available")

@pd_skip
@hdf5_skip
def test_data_frame_hdf5(self):
path = '{}/val.h5'.format(self.temp_dir)
P.data_frame.to_hdf(path, 'df')
self._test_deserialize_array(P, path, 'data_frame')
path = '{}/val.hdf5'.format(self.temp_dir)
P.data_frame.to_hdf(path, 'df')
self._test_deserialize_array(P, path, 'data_frame')

@maximlt
Copy link
Member

maximlt commented Nov 6, 2023

tables is actually installed when the CI runs on Linux:

param/pyproject.toml

Lines 191 to 196 in e9b2781

# Only install gmpy on Linux on these version
# Only install tables (deser HDF5) on Linux on these version
matrix.python.dependencies = [
{ value = "gmpy", if = ["3.8", "3.9", "3.10"], platform = ["linux"] },
{ value = "tables", if = ["3.8", "3.9", "3.10", "3.11", "3.12"], platform = ["linux"] },
]

And you can verify the test is not skipped:
https://github.com/holoviz/param/actions/runs/6761543745/job/18376521753#step:7:595

It's just that the dependencies declaration is a little convoluted in pyproject.yml, and that in the end the tests-deser isn't used at all. I'll merge your PR though since anyway tables should be in tests-deser.

@maximlt maximlt merged commit c30ae02 into holoviz:main Nov 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants