-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby or Rails Capstone project #9
Conversation
Create user, category and spending models and migrations
Authorization
Add a splash screen with logo and login signup buttons
Categories
Transactions
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Hombre2014,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Your commit and pull request message messages are very descriptive ✔️
- Good presentation ✔️
- All your test are passing ✔️
- No Linter errors ✔️
Required Changes ♻️
- This project should be deployed using Heroku, Netlify or GitHub Pages. Kindly add link of online projec t in your readme file.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Thanks for the fast review. Tha site has been deployed, I just forgot to put the link in the README file. Now it is there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STATUS: APPROVED 🥳 🥳 🥳
@Hombre2014 ✋🏼
Your project is great. 🎉 I approve of it. There is nothing else to say other than... it's time to merge it. You can submit this project on your dashboard.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding! 💻 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Reviewed by Ahmet Bozacı
This is my PR for review between dev and main branches. All the requirements for this project have been implemented as follow:
Project requirements
Design
Original design idea by Gregoire Vella on Behance.
The Creative Commons license of the design requires that you give appropriate credit to the author. Therefore, you must do it in the README of your project.
Interactions
Splash screen
Sign up and log in pages
Home page (catagories page)
Transactions page
"Add a new category" page
"Add a new transaction" page
Testing requirements
Technical requirements
ERD diagram
Project documentation
Once you have finished the development of the project, you should record a video presenting the features of the project you built. It is a video with a maximum length of 5 minutes. The content of the video should include: