Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby or Rails Capstone project #9

Merged
merged 44 commits into from
Apr 29, 2022
Merged

Ruby or Rails Capstone project #9

merged 44 commits into from
Apr 29, 2022

Conversation

Hombre2014
Copy link
Owner

This is my PR for review between dev and main branches. All the requirements for this project have been implemented as follow:

Project requirements

Design

  • You should follow these design guidelines, including:
    • Colors.
    • Typography: font face, size and weight.
    • Layout: composition and space between elements.

NOTE: In these design guidelines there are several UIs that you won't need for this exercise; also, some pages are not given a design and you will create them following the design guidelines of the other pages.

Original design idea by Gregoire Vella on Behance.

The Creative Commons license of the design requires that you give appropriate credit to the author. Therefore, you must do it in the README of your project.

Interactions

  • Splash screen

    • A simple page with the name of your app (yes, you need to choose one), and links to the sign up and log in pages.
  • Sign up and log in pages

    • The user should be able to register in the app with full name, email and password (all mandatory).
    • The user can log into the app using email and password.
    • If the user is not logged in, they can't access pages that require the user to be logged in (all the pages described below).
  • Home page (catagories page)

    • When the user logs in, they are presented with the categories page.
    • For each category, the user can see their name, icon and the total amount of all the transactions that belongs to that category.
    • When the user clicks (or taps) on a category item, the application navigates to the transactions page for that category.
    • There is a button "add a new category" at the bottom that brings the user to the page to create a new category.
  • Transactions page

    • For a given category, the list of transactions is presented, ordered by the most recent.
    • At the top of the page the user could see the total amount for the category (sum of all of the amounts of the transactions in that category).
    • There is a button "add a new transaction" at the bottom that brings the user to the page to create a new transaction.
    • When the user clicks on the "Back" button (<), the user navigates to the home page.
  • "Add a new category" page

    • The user fills out a form to create a new category, indicating their name and icon (both mandatory).
    • The user click (or taps) the "Save" button to create the new category, and is taken to the home page on success.
    • When the user clicks on the "Back" button (<), the user navigates to the home page.
  • "Add a new transaction" page

    • The user fills out a form to create a new transaction with:
      • name (mandatory)
      • amount (mandatory)
      • categories (mandatory at least one)
    • The user click (or taps) the "Save" button to create the new category, and is taken to the transactions page for that category.
    • When the user clicks on the "Back" button (<), the user navigates to the transactions page for that category.

Testing requirements

  • Create unit and integration tests for all the most important components of your RoR application.

Technical requirements

  • You should use Postgres as your database.
  • You should use devise for authentication.
  • You should validate all user input to make sure that anyone with bad intentions cannot compromise your app.
  • You can use a view template engine of your choice (.erb, .slim, .haml).
  • The project should be deployed and accessible online.
  • Your database schema should reflect the following structure:

NOTE: do not change column names visible in the diagram. You need to change the "Entity" name according to the theme you have chosen for your project (please note: "Transaction" is a name already used by ActiveRecord, so using it as a name for your model and table will result in an error).

ERD diagram

Project documentation

Once you have finished the development of the project, you should record a video presenting the features of the project you built. It is a video with a maximum length of 5 minutes. The content of the video should include:

  • a description of the project.
  • a demo of the project features.
  • you should also highlight some interesting piece of code or something you built that you are very proud of.

Hombre2014 and others added 30 commits April 25, 2022 11:36
Create user, category and spending models and migrations
Add a splash screen with logo and login signup buttons
@netlify

This comment was marked as outdated.

@gitguardian

This comment was marked as off-topic.

Copy link

@uwadonat uwadonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Hombre2014,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • Your commit and pull request message messages are very descriptive ✔️
  • Good presentation ✔️
  • All your test are passing ✔️
  • No Linter errors ✔️

almost

Required Changes ♻️

  • This project should be deployed using Heroku, Netlify or GitHub Pages. Kindly add link of online projec t in your readme file.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Hombre2014
Copy link
Owner Author

Thanks for the fast review. Tha site has been deployed, I just forgot to put the link in the README file. Now it is there.

Copy link

@ahmetbozaci ahmetbozaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED 🥳 🥳 🥳

@Hombre2014 ✋🏼

Your project is great. 🎉 I approve of it. There is nothing else to say other than... it's time to merge it. You can submit this project on your dashboard.


Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.


Cheers and Happy coding! 💻 👏

aproved


Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

GitHub | LinkedIn | Twitter

Reviewed by Ahmet Bozacı

@Hombre2014 Hombre2014 merged commit ec32966 into main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants