-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use httpx instead of aiohttp #78
Conversation
|
That is not correct, and not wished for. See also: https://developers.home-assistant.io/docs/review-process#what-not-to-do
Thanks 👍 |
Ah, sorry. Thanks for correcting frenck. |
So what’s the process for getting this merged? Should I ping someone, or do I just wait? |
Other than that change, everything looks good and works for me on my Prusa XL with 5.1.2+13478 Firmware. |
Co-authored-by: Niklas Wagner <Skaro@Skaronator.com>
Also for me, it works on Prusa MK4 with 5.1.2 and Prusa MK3S+ with PrusaLink 0.7.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, aiohttp is generally preferred, but since digest auth is not supported (yet) httpx is the only option here.
Oops, I forgot to check formatting. It should be good now. |
Thanks, I'll try to create the Edit: Assuming there'll be a new release. |
Thank you for your work 🙏 🤩 Release: I'll try to make it happen 😄 |
@agners I was finally working on the |
@the-ress ugh I see missed the version bump 🙈 I've just created a new, proper release 2.1.1, this time all green 🎉 . |
It took me a bit longer, but here it is: home-assistant/core#114210 |
Fixes #77.
Also includes a workaround for encode/httpx#3045 and prusa3d/Prusa-Firmware-Buddy#3665. The workaround can be removed once they're resolved.