nhttp: Support unquoted Authorization header parameters #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2024
Closed
vorner
reviewed
Jan 11, 2024
utils/gen-automata/http.py
Outdated
| value = auto.add_state() | ||
| quote = auto.add_state() | ||
| value_quoted = auto.add_state() | ||
| value_quoted = auto.add_state() |
There was a problem hiding this comment.
Do we need two value_quoted?
There was a problem hiding this comment.
Oh, that's a typo I missed. I removed it.
the-ress
force-pushed
the
unquoted-authorization-parameters
branch
from
e8fba38
to
5c5b3c3
Compare
vorner
approved these changes
Jan 15, 2024
|
Thank you. I expect this'll get released in the next non-patch release (5.2, not 5.1.3), though I can't guarantee it. |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When authenticating using the Digest scheme, some HTTP clients (e.g. httpx) send the
algorithmparameter even when it was not explicitly specified by the server in theWWW-Authenticateheader. The value is being sent without quotes as required by RFC 7616. This trips up the parsing which only expects quoted parameters and the server return error 400.Example header:
Additionally, I noticed the scheme part (
Digest) wasn't consumed separately and got attached to the first param instead. In a header like this, withnonceas the first parameter, its name would be understood asDigest nonceinstead of justnonceand the value would get ignored.Changes
Digestscheme at the start is consumed before parsing the parameters. The actual value isn't checked, following the existing pattern. (We only really read nonce and response, the rest is assumed for performance reasons.)separator -> read_partransition is now fallthrough so it doesn't eat the first char of the value (", first char of an unquoted value, etc.)