-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RFC 2069 mode digest authentication #3045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2024
Closed
tomchristie
reviewed
Jan 8, 2024
I appreciated your "this branch is RFC ..." comment in #2600 (comment) - perhaps we should include those? Also the link to the |
the-ress
force-pushed
the
fix-rfc-2069-digest-auth
branch
from
January 8, 2024 18:04
0b051a3
to
7124189
Compare
I made the discussed changes and added a few tests. |
tomchristie
reviewed
Jan 9, 2024
Looking wonderful, thanks. ✨😊✨ You'll also want to update the |
Done. |
T-256
approved these changes
Jan 10, 2024
tomchristie
approved these changes
Jan 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a typo that breaks old RFC 2069 mode digest auth.
The issue is that HA1 is added both on line 283, and again on line 293. (According to RFC, it should be there only once.)
Also mentioned in #2788 (comment)
Checklist