Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
close
truly synchronous by:ser.flush()
when closing the serial port. This is a breaking change but I don't think it was correct to wait forflush
to be called anyways.ser.close()
within the event loop, not in an executor thread. I believe this should be safe given the implementation. All of the file descriptors are opened in non-blocking mode.For background on point 2, see pyserial#82. I believe that this codepath (TCP
socket://
URIs) is now properly special cased and handled within pyserial-asyncio-fast. At this point, pyserial should be used only for serial ports.Fixes #7.