Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not open serial ports exclusively by default #1422

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

puddly
Copy link
Collaborator

@puddly puddly commented Jul 13, 2024

Partially reverts #1418.

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (92e9746) to head (32f6836).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1422   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          55       55           
  Lines       10417    10417           
=======================================
  Hits        10365    10365           
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly puddly marked this pull request as draft July 13, 2024 17:25
@puddly
Copy link
Collaborator Author

puddly commented Jul 13, 2024

Looks like this is not enough! Needs more investigation 🤔

@puddly puddly marked this pull request as ready for review July 14, 2024 00:54
@puddly
Copy link
Collaborator Author

puddly commented Jul 14, 2024

exclusive is blocked by home-assistant-libs/pyserial-asyncio-fast#15.

@puddly puddly merged commit 0bcd370 into zigpy:dev Jul 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant