Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow user to press back to log out #76

Closed
Kisty opened this issue Nov 26, 2019 · 8 comments
Closed

Don't allow user to press back to log out #76

Kisty opened this issue Nov 26, 2019 · 8 comments

Comments

@Kisty
Copy link
Contributor

Kisty commented Nov 26, 2019

First off, this is great to see an official HA app. Well done! 👏👏👏

I found that by pressing back too many times logged me out of HA. This is a UX bug. See #75.

@quthla
Copy link
Contributor

quthla commented Nov 26, 2019

This is a frontend issue so must be fixed there.

@balloob
Copy link
Member

balloob commented Nov 26, 2019

Shouldn't we just start a new webview for the website, so there is no history of the login page to back to.

The person didn't get logged out but just navigated back to the login page. Killing app and reopening would have solved it.

@andriej
Copy link

andriej commented Nov 26, 2019

It would, it happened to mee too.

@quthla
Copy link
Contributor

quthla commented Nov 26, 2019

Shouldn't we just start a new webview for the website, so there is no history of the login page to back to.

The person didn't get logged out but just navigated back to the login page. Killing app and reopening would have solved it.

I think the issue is rather that when navigating back from an external page to a HA page, the frontend will not ask the app for authentication again and just show the login.

@balloob
Copy link
Member

balloob commented Nov 26, 2019

#75 will help.

The issue is that we change the url and it forgets it was using external auth. Indeed a frontend issue. I wonder if we need to chanfe how we detect external auth. Maybe we should check if some JS object exists instead?

@quthla
Copy link
Contributor

quthla commented Nov 27, 2019

#75 will help.

The issue is that we change the url and it forgets it was using external auth. Indeed a frontend issue. I wonder if we need to chanfe how we detect external auth. Maybe we should check if some JS object exists instead?

You could try checking if the externalApp interface is present.

@andriej
Copy link

andriej commented Nov 27, 2019

It happened to me also on "new ui available" and reload of lovelace. After refresh - login screen. Killing app and reopening fixed situation.

@balloob
Copy link
Member

balloob commented Nov 27, 2019

Fixes in home-assistant/frontend#4280

@balloob balloob closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants