Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt at a new release model. #3597

Merged
merged 6 commits into from
Jun 26, 2023
Merged

Conversation

JBassett
Copy link
Collaborator

@JBassett JBassett commented Jun 19, 2023

Summary

Attempting to simplify the release cycle and hopefully improve our review times with Google. Our weekly play store release will now be tagged and ready for promotion rather than needing another review.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@JBassett JBassett marked this pull request as ready for review June 20, 2023 00:39
@jpelgrom
Copy link
Member

This also seems to remove the automated deploy to the Amazon App Store, correct?

@JBassett
Copy link
Collaborator Author

This also seems to remove the automated deploy to the Amazon App Store, correct?

Yeah, it appears that it was only staging the deploy and manual intervention was needed to actually release it with the old system. If we find a tool that will actually release the update I would love to add it back in.

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to understand what will happen:

  • all building happens in onPush.yml
  • building + internal track push happens on merge or tag
  • GitHub pre-release and internal track to beta track push happens on tag
  • tags are created weekly and on the first of each month, and will create a GitHub pre-release
  • stable releases aren't new tags but instead editing an existing pre-release/tag

Assuming that is correct, won't the scheduled activities push more 'new' releases where there might not be any changes (= same release contents and version), which the Play Store will reject?

./gradlew :reckonTagPush -Preckon.stage=final doesn't work for me locally with the error 'Task '.stage=final' not found in root project 'home-assistant-android' and its subprojects.' but as it is in the documentation I'm not sure if it doesn't work or if it's something in my environment.

.github/workflows/monthly.yaml Outdated Show resolved Hide resolved
@@ -92,6 +92,10 @@ jobs:
restore-keys: |
${{ runner.os }}-gradle-

- uses: ./.github/actions/create-release-number
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do PRs get a release number now? Local builds work fine without running the action, I got version name 2023.6.1-beta.0.14+a532fb4 without any config.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was primarily using it to test, but since it's not signed with the real keys it should be safe to have actual version/build numbers in PRs.

.gitignore Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@JBassett
Copy link
Collaborator Author

./gradlew :reckonTagPush -Preckon.stage=final doesn't work for me locally with the error 'Task '.stage=final' not found in root project 'home-assistant-android' and its subprojects.' but as it is in the documentation I'm not sure if it doesn't work or if it's something in my environment.

Think this is a problem with your setup, I validated again and it was working.

@JBassett
Copy link
Collaborator Author

Assuming that is correct, won't the scheduled activities push more 'new' releases where there might not be any changes (= same release contents and version), which the Play Store will reject?

Adding the tag will bump the version number making it a "new" build.

Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience with the answers.

Let's see if this flow improves the release process :)

@JBassett JBassett merged commit 0ef3bc4 into master Jun 26, 2023
4 checks passed
@JBassett JBassett deleted the feature/newReleaseModel branch June 26, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants