Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex matching to zeroconf service names #306

Closed
jcalbert opened this issue Oct 24, 2019 · 3 comments
Closed

Add regex matching to zeroconf service names #306

jcalbert opened this issue Oct 24, 2019 · 3 comments

Comments

@jcalbert
Copy link

Home Assistant release with the issue: 0.101.0.dev0

Last working Home Assistant release (if known): N/A

Operating environment (Hass.io/Docker/Windows/etc.): N/A

Description of problem:
Per home-assistant/core#27371 (comment), home-assistant/core#27371 (comment), home-assistant/core#27371 (comment)
Add regex matching for devices with specimen-unique zeroconf service names.

example:
Rainforest Automation's device's zeroconf have the form
eagle-012abc._http._tcp
so the associated zerconf entry in manifest.json would be
"zeroconf": ["eagle-[0-9a-f]{6}._http._tcp.local."],

Additional information:

@probot-home-assistant

This comment has been minimized.

@balloob
Copy link
Member

balloob commented Oct 24, 2019

I agree that we should do this.

I don't like overloading the type with a name regex. I think that we should go for something like this:

"zeroconf": [
  { "type": "_http._tcp", "name": "eagle-[0-9a-f]{6}._http._tcp.local."}
]

This can be made backwards compatible by assuming string values are just types. Name is optional.

@frenck
Copy link
Member

frenck commented Jan 26, 2021

This has been implemented, not with regular expression, but we have wildcard support (*), which has been proven sufficient for our use case.

@frenck frenck closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants