New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added icons and logos for Bosch SHC integration. #1164
Conversation
I see where the logo source comes from, but I'm thinking the logo should just be the Bosch medallion and name? Let's get a second opinion from @frenck |
Yeah, I agree with you. We are looking for logo's, not product presentation images. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tschamm Yes, the two files I provided are sized and ready to go if you want to add them |
Guys, Bosch logo is already present as high quality transparent logo and icon in bmp280. I suggest to remove this PR and open a new one by symlinking boschshc to bmp280. No need for duplicate images. Other Bosch devices are symlinked too: bme280/, bme680/ ---> bmp280/ |
Thanks, @adrianmihalko absolutely correct 👍 |
Thanks, good point! |
One more thing, logo is not high quality + has white space around it + not transparent: Please use this one, if you want flat logo: https://worldvectorlogo.com/logo/bosch-logo-simple Or classic: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
The upstream HACS default PR fails without this being merged. |
@tschamm This one cannot be merged against a custom integration, as this PR add graphics for a core intrgation. |
You're totally right of course, I'm sorry. I'll add another PR for the custom integration. |
Proposed change
New integration which introduces support for devices managed by the Bosch Smart Home Controller system. PR for home-assistant.io doc and home-assistant core repos are in preparation.
Type of change
Additional information
Checklist
icon.png
)icon@2x.png
)logo.png
)logo@2x.png
)