Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation for new boschshc integration #12842

Merged
merged 6 commits into from May 14, 2021
Merged

Added documentation for new boschshc integration #12842

merged 6 commits into from May 14, 2021

Conversation

tschamm
Copy link
Contributor

@tschamm tschamm commented Apr 11, 2020 •
edited

Proposed change

New integration which introduces support for devices managed by the Bosch Smart Home Controller system. PR for home-assistant.io doc and home-assistant core repos are in preparation.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Apr 11, 2020
@probot-home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

@probot-home-assistant probot-home-assistant bot added the next This PR goes into the next branch label Apr 11, 2020
This was referenced Apr 11, 2020
Merged
Merged
@frenck frenck added this to To Do in New documentation via automation Apr 12, 2020
frenck
frenck requested changes Apr 12, 2020
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @tschamm!

I've reviewed it and left some small comments. Could you take a look? Thanks! 👍

source/_integrations/boschshc.markdown Outdated Show resolved Hide resolved
source/_integrations/boschshc.markdown Outdated Show resolved Hide resolved
source/_integrations/boschshc.markdown Outdated Show resolved Hide resolved
@frenck frenck removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Apr 12, 2020
@frenck frenck moved this from To Do to In Progress in New documentation Apr 12, 2020
@frenck frenck removed the in-progress This PR/Issue is currently being worked on label Apr 12, 2020
New documentation automation moved this from In Progress to Awaiting Parent PR Apr 12, 2020
frenck
frenck previously approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.
⚠️ The ha_release might need an update before merging this one in.

@frenck frenck added awaits-parent Awaits the merge of an parent PR new-integration This PR adds documentation for a new Home Assistant integration labels Apr 12, 2020
This was referenced Jan 25, 2021
Merged
Merged
@MartinHjelmare MartinHjelmare added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels May 14, 2021
@project-bot project-bot bot moved this from Awaiting Parent PR to Parent Merged in New documentation May 14, 2021
frenck
frenck requested changes May 14, 2021
View reviewed changes
source/_integrations/bosch_shc.markdown Outdated Show resolved Hide resolved
source/_integrations/bosch_shc.markdown Outdated Show resolved Hide resolved
source/_integrations/bosch_shc.markdown Outdated Show resolved Hide resolved
@frenck frenck added the in-progress This PR/Issue is currently being worked on label May 14, 2021
@frenck frenck moved this from Parent Merged to In Progress in New documentation May 14, 2021
@tschamm @frenck
Apply suggestions from code review
65b2395 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@tschamm tschamm requested a review from frenck May 14, 2021 19:06
New documentation automation moved this from In Progress to Awaiting Parent PR May 14, 2021
frenck
frenck approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@frenck frenck merged commit 91e5171 into home-assistant:next May 14, 2021
New documentation automation moved this from Awaiting Parent PR to Done May 14, 2021
@probot-home-assistant probot-home-assistant bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees

@tschamm tschamm

Labels
cla-signed has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
No open projects
New documentation
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tschamm @frenck @MartinHjelmare @homeassistant