Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sharkiq files to core integrations #1762

Merged
merged 1 commit into from Aug 31, 2020
Merged

Move sharkiq files to core integrations #1762

merged 1 commit into from Aug 31, 2020

Conversation

ajmarks
Copy link
Contributor

@ajmarks ajmarks commented Jul 27, 2020 •
edited

Proposed change

Move the sharkiq files from custom_integrations to core_integrations

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@ajmarks ajmarks mentioned this pull request Jul 27, 2020
Merged
8 tasks
@frenck frenck added the has-parent This PR has a parent PR in a other repo label Jul 27, 2020
frenck
frenck previously approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jul 27, 2020
@frenck frenck added the parent-merged The parent PR has been merged already label Aug 30, 2020
@frenck
Copy link
Member

frenck commented Aug 31, 2020

rebased the PR to resolve the merge conflicts

@frenck frenck removed the parent-merged The parent PR has been merged already label Aug 31, 2020
@frenck frenck merged commit 9243426 into home-assistant:master Aug 31, 2020
@frenck frenck removed the awaits-parent Awaits the merge of an parent PR label Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajmarks @frenck