Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Rointe Heaters icons #3647

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Adds Rointe Heaters icons #3647

merged 4 commits into from
Sep 19, 2022

Conversation

tggm
Copy link
Contributor

@tggm tggm commented Sep 10, 2022

Proposed change

Adds logo and icon for the Rointe Heaters custom integration (HACS).

Type of change

  • Add a new logo or icon for a new core integration
  • [] Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom HACS integration: https://github.com/tggm/rointe-hacs

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@homeassistant
Copy link

Hi @tggm,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons provided in this PR seem different than the icon the brand uses, for example, on their socials:

image

The logo also seems different compared to the branding they use on their website:

CleanShot 2022-09-13 at 13 21 31

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Sep 13, 2022
@tggm
Copy link
Contributor Author

tggm commented Sep 18, 2022

Icons updated as requested.

@tggm tggm requested a review from frenck September 18, 2022 17:51
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tggm 👍

@frenck frenck merged commit 8af35cf into home-assistant:master Sep 19, 2022
@tggm tggm deleted the rointe-heaters branch September 19, 2022 13:04
KartoffelToby pushed a commit to KartoffelToby/brands that referenced this pull request Sep 24, 2022
tsunglung pushed a commit to tsunglung/brands that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed in-progress This PR/Issue is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants