Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dark logos #4013

Merged
merged 2 commits into from
Feb 1, 2023
Merged

added dark logos #4013

merged 2 commits into from
Feb 1, 2023

Conversation

redlukas
Copy link
Contributor

@redlukas redlukas commented Jan 6, 2023

Proposed change

  • Add dark version of logos
  • better feathering for the light version

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dark variant of logo's are ment for making sure some icons show up on a dark background correctly.
That said, the original logo is already transparent and does not have dark mismatching color itself.

Hence I'm not understanding the dark icons added:

image

Those have a dark background, but isn't that what the original icon already tries to solve?

IMHO this result is worse than using the existing transparent icons

@frenck frenck added the in-progress This PR/Issue is currently being worked on label Jan 6, 2023
@redlukas
Copy link
Contributor Author

redlukas commented Jan 6, 2023

Ok, the icons with transparent layer show up well on a dark background. but the Emu head on the logo is just a pair of floating eyes when the image has the transparancy layer and the background is dark enough. therefore, I think the dark_logo add to the experience. @frenck do you agree or should I remove them as well?

This is how the logo looks in the default dark theme:
image

@redlukas redlukas requested a review from frenck January 6, 2023 14:31
@redlukas redlukas removed their assignment Jan 30, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that is fine 👍

Thanks, @redlukas 👍

../Frenck

@frenck frenck merged commit eeb5e31 into home-assistant:master Feb 1, 2023
tsunglung pushed a commit to tsunglung/brands that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress This PR/Issue is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants