Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Logos are shown #117977

Closed
fft1010 opened this issue May 23, 2024 · 10 comments
Closed

Wrong Logos are shown #117977

fft1010 opened this issue May 23, 2024 · 10 comments
Assignees

Comments

@fft1010
Copy link

fft1010 commented May 23, 2024

The problem

Hi,
before Version 2024.5.0 the Logos that where shown where the logos of the manufacturer of the device. Now neraly all devices that are connected thru WLAN show the Logo from Unify, which is the device, that provides WLAN.

Nearly all shelly devices (except one) are effected, One ESPHome device I have is affected, and ESPSomfy is not affected. See here the screenshot for explanation:

wrong-logo

The marked shelly plug was added at the same time with the same 2024.4.3 version as other plugs that now show the wrong logo. I noticed, that in some detailed view (device shown), the order of the wrong logos shows Unify as the first, than shelly, than fritzbox.

If you need more infos, than tell me, what I should upload as well, I do not want to clutter all the space here.

thanks
Juergen

What version of Home Assistant Core has the issue?

core-2024.5.4

What was the last working version of Home Assistant Core?

core-2024.4.4

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @Kane610, mind taking a look at this issue as it has been labeled with an integration (unifi) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifi can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign unifi Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


unifi documentation
unifi source
(message by IssueLinks)

@rrooggiieerr
Copy link
Contributor

rrooggiieerr commented May 24, 2024

Devices can be covered by multiple integrations like for instance Nmap Tracker and ESPHome:
Screenshot 2024-05-24 at 16 09 42

In those cases it's just random whichever logo is shown for the device.

In your case the device is covered by both the Shelly and Unify integration.

@Kane610
Copy link
Member

Kane610 commented May 24, 2024

Hello, this is how the implementation is today. There are discussions about identifying primary and secondary providers of entities to improve this but that is out of scope for a bug report.

@Kane610 Kane610 closed this as completed May 24, 2024
@mib1185
Copy link
Contributor

mib1185 commented May 24, 2024

Hello, this is how the implementation is today. There are discussions about identifying primary and secondary providers of entities to improve this but that is out of scope for a bug report.

this is already implemented since 2023.8 (with #95641)

@Kane610
Copy link
Member

Kane610 commented May 25, 2024

Hello, this is how the implementation is today. There are discussions about identifying primary and secondary providers of entities to improve this but that is out of scope for a bug report.

this is already implemented since 2023.8 (with #95641)

Sure, I formulated myself poorly. But AFAIK it's just a step towards identifying which source is primary so it's not solved all the way yet. The integration does provide the default_* attributes for clients

@fft1010
Copy link
Author

fft1010 commented May 25, 2024

Hi @rrooggiieerr ,

Devices can be covered by multiple integrations like for instance Nmap Tracker and ESPHome: <img alt="Screenshot 2024-05-24 at 16 09 42" width="342" src="https://private-user-images.githubusercontent.com/18603534/333619406-cde5675e-9004-4acc-848f-

In your case the device is covered by both the Shelly and Unify integration.

I now what happens, and it is for sure true, that the device is covered by multiple integration, and in the device overview it is a nice feature to see all the logos.
But refer to the overview in my screenshot. There the logos are shown from the WLAN connection provider, which is imho useless, as for sure all WLAN devives are connected and detected by this integration. So it does not give any more information there, so better leave it out to save space.
Plus the fact, that one device shows the other logo (but has wlan logo in the device overview), makes me „wonder“ to say the least.
Plus the fact that it worked before the update to 2024.5.3 makes it a bug in my opinion.
Anyway. I will avoid updates in the future. Let others walk thru the update problem. I like a reliable system better than a fast, random system.

thanks
Juergen

@Kane610
Copy link
Member

Kane610 commented May 25, 2024

Hi @rrooggiieerr ,

Devices can be covered by multiple integrations like for instance Nmap Tracker and ESPHome: <img alt="Screenshot 2024-05-24 at 16 09 42" width="342" src="https://private-user-images.githubusercontent.com/18603534/333619406-cde5675e-9004-4acc-848f-
In your case the device is covered by both the Shelly and Unify integration.

I now what happens, and it is for sure true, that the device is covered by multiple integration, and in the device overview it is a nice feature to see all the logos. But refer to the overview in my screenshot. There the logos are shown from the WLAN connection provider, which is imho useless, as for sure all WLAN devives are connected and detected by this integration. So it does not give any more information there, so better leave it out to save space. Plus the fact, that one device shows the other logo (but has wlan logo in the device overview), makes me „wonder“ to say the least. Plus the fact that it worked before the update to 2024.5.3 makes it a bug in my opinion. Anyway. I will avoid updates in the future. Let others walk thru the update problem. I like a reliable system better than a fast, random system.

thanks Juergen

AFAIK there has been no recent changes to this area but can differ between every restart of hass. Your statement about your upgrade strategy is irrelevant to this issue stay on topic.

@fft1010
Copy link
Author

fft1010 commented May 25, 2024

I startet the HA quite often in 2024.4.4 and before, and it neveer was an issue. The randomness of the logos than came in in 2024.5.3.
And „fastness“ seemed to be a major feature. I only vote for reliability.
But you are right. Case closed.

@Kane610
Copy link
Member

Kane610 commented May 25, 2024

This is also a purely aesthetic problem, I am happy its not a functional issue :)

@fft1010
Copy link
Author

fft1010 commented May 25, 2024

If not handled, it might be sooner or later a functional problem as well, as there seem to be informations not used at least at this point, that might/should/could be handled. I would bet anything that this will be a functional problem.
Anyway… let‘s keep out fingers crossed, that asthetical and functional do not split too much.

form follows function :-)

So if I see „bad form“,…

@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants