-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Siri requests target heating cooling state of auto even when its not a valid value #60203
Comments
homekit_controller documentation |
Hey there @Jc2k, @bdraco, mind taking a look at this issue as it has been labeled with an integration ( |
The exception is in pyhap, which is part of the homekit bridge, not homekit_controller. The question is whether Siri is generating unexpected data that the bridge doesn't like, or whether it's homekit_controller. Do you only get these errors with Siri and not when you use the HA Ui? What about the Apple Home app? |
Does the Ha UI correctly see the valid modes? (It dossnt show auto or cooling?) Does the Apple Home app show the correct modes? |
Looking at the other issue I'm going to pre-emptively move this issue as it looks like it's homekit, not homekit_controller. |
homekit documentation |
Siri is asking for Auto even though its not a valid value HC_HEAT_COOL_AUTO = 3 We had another user experience this siri issue a while back. I'll see if I can find how it was solved |
Related PR #44236 |
😆 Looks like I'm actually remembering your previous issue #44076 |
|
I don't see a way to fix this without removing the validation from |
With hkc, we bend over backwards to cope with the same bugs in devices that iOS copes with (like the hideous JSON trailing comma that we dealt with a while back). I think this is the same situation. iOS/Siri is doing something dumb, but it is "always right" so we have to deal with it? I.e. we should tolerate crap coming in, but follow the spec for stuff we are sending out. We could clamp all ints to minValue/maxValue. This makes sense for things like temperature (if you request -5 C, we'll get you as close as possible but it might only be 10 C). And it happens to work here, maxValue is |
(To be clear: pyhap clamps to minValue/maxValue for stuff coming from iOS to HA, but still validates for stuff coming from HA to iOS) |
As of iOS 15.1, Siri requests TargetHeatingCoolingState as Auto reguardless if its a valid value or not. Consumers of this api may wish to set allow_invalid_client_values to True and handle converting the Auto state to Cool or Heat depending on the device. Reference: home-assistant/core#60203
As of iOS 15.1, Siri requests TargetHeatingCoolingState as Auto reguardless if its a valid value or not. Consumers of this api may wish to set allow_invalid_client_values to True and handle converting the Auto state to Cool or Heat depending on the device. Reference: home-assistant/core#60203
- Siri will request an invalid thermostat mode (auto) when the device does not support it. Allow the value to be converted to a mode the device supports - Requires ikalchev/HAP-python#392 - Fixes home-assistant#60203
I created a workaround for this issue in #60220 We will have to wait for a new release of |
The problem
I have a Tado Thermostat in HomeKit via the HA HomeKit Controller. When turning the thermostat on or changing the temperature via Siri, I get two errors within the HA logs.... however the temperature still changes as expected.
The thermostat only supports heating (off, heat) and there is no cooling element.
I am unsure if it is related, though I did report a simular issue this time last year #44076
These particular errors showed when asking Siri to turn the temperature to 22 degrees. (The current temp was 21 and the thermostat was in the 'off' state).
Error 1
Error 2
What version of Home Assistant Core has the issue?
Core
What was the last working version of Home Assistant Core?
No response
What type of installation are you running?
Home Assistant Container
Integration causing the issue
HomeKit Controller
Link to integration documentation on our website
https://www.home-assistant.io/integrations/homekit_controller/
Example YAML snippet
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: