Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZHA] ZHA System modes are not in agreement with ZCL (and zigpy) System Modes #60450

Closed
PLTorrent opened this issue Nov 27, 2021 · 3 comments
Closed
Assignees

Comments

@PLTorrent
Copy link

The problem

System modes defined here:

are not in agreement with ZCL specification or Zigpy modes:

https://github.com/zigpy/zigpy/blob/1d69fc4d5aa724ce652cf002364879a25d30677c/zigpy/zcl/clusters/hvac.py#L215

Namely instead of Auto mode there is "heat_cool" mode with 'heat_cool' literal instead of auto.

From ZCL spec: https://zigbeealliance.org/wp-content/uploads/2019/12/07-5123-06-zigbee-cluster-library-specification.pdf

image

What version of Home Assistant Core has the issue?

core-2021.11.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

ZHA

Link to integration documentation on our website

https://www.home-assistant.io/integrations/zha/

Example YAML snippet

No response

Anything in the logs that might be useful for us?

File "/workspaces/ha-dev/homeassistant/components/zha/climate.py", line 439, in async_set_hvac_mode
    if await self._thrm.async_set_operation_mode(HVAC_MODE_2_SYSTEM[hvac_mode]):
KeyError: 'auto'

Additional information

No response

@probot-home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this issue as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)


zha documentation
zha source
(message by IssueLinks)

@Adminiuga
Copy link
Contributor

SystemMode.Auto was named to matched HA HVAC action of "heating" or "Cooling" automatically.
Why is this a problem?

@PLTorrent
Copy link
Author

Now it's clear, thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants