Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot play media containing a forward slash #78674

Closed
natefelt opened this issue Sep 18, 2022 · 5 comments · Fixed by #84865
Closed

Cannot play media containing a forward slash #78674

natefelt opened this issue Sep 18, 2022 · 5 comments · Fixed by #84865

Comments

@natefelt
Copy link

The problem

Apologies if this is an easy fix that I've overlooked...

I'm unable to play media where the artist, album, or genre name contains a forward slash (/) using the media_player.play_media service. Enclosing the name or entire media_content_id string in quotes doesn't work.

Works:
media_content_id: Library/Artists/Volbeat/Rewind, Replay, Rebound
media_content_id: Library/Genres/Jazz

Does not work:
media_content_id: Library/Artists/Volbeat/Rock the Rebel/Metal the Devil
media_content_id: "Library/Artists/Volbeat/Rock the Rebel/Metal the Devil"
media_content_id: "Library/Artists/Volbeat/'Rock the Rebel/Metal the Devil'"
media_content_id: Library/Genres/Pop/Rock

What version of Home Assistant Core has the issue?

2022.9.4

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

roon

Link to integration documentation on our website

https://www.home-assistant.io/integrations/roon

Diagnostics information

No response

Example YAML snippet

service: media_player.play_media
data:
  media_content_type: music
  media_content_id: Library/Artists/Volbeat/Rock the Rebel/Metal the Devil
target:
  entity_id: media_player.roon

Anything in the logs that might be useful for us?

Playback request for music / Library/Artists/Volbeat/Rock the Rebel/Metal the Devil / ['Library', 'Artists', 'Volbeat', 'Rock the Rebel', 'Metal the Devil'] was unsuccessful
Playback request for music / Library/Artists/Volbeat/'Rock the Rebel/Metal the Devil' / ['Library', 'Artists', 'Volbeat', "'Rock the Rebel", "Metal the Devil'"] was unsuccessful
Playback request for music / Library/Artists/Volbeat/Rock the Rebel//Metal the Devil / ['Library', 'Artists', 'Volbeat', 'Rock the Rebel', 'Metal the Devil'] was unsuccessful

Additional information

No response

@probot-home-assistant
Copy link

roon documentation
roon source
(message by IssueLinks)

@probot-home-assistant
Copy link

Hey there @pavoni, mind taking a look at this issue as it has been labeled with an integration (roon) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@pavoni
Copy link
Contributor

pavoni commented Sep 18, 2022

The integration just uses a simple library call to split the path into the individual components - so I’m not surprised it doesn’t handle quoted strings.

As a work round could you change the track name in roon? Perhaps a dash?

@natefelt
Copy link
Author

Ok. Glad it is a library issue and not something simple I was overlooking. Replacing the forward slash with a dash would work and if it was just a handful of tracks affected I'd likely consider doing that. Unfortunately, the issue also affects genres and sub-genres and would require a lot of manual changes to the library to work around the problem.

@github-actions github-actions bot added the stale label Oct 18, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2022
@pavoni pavoni reopened this Dec 30, 2022
@pavoni
Copy link
Contributor

pavoni commented Dec 30, 2022

Re-opened since I now have a fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants