Add Husqvarna Automower integration #100569

Thomas55555 · 2023-09-18T21:53:18Z

Breaking change

Proposed change

Add Husqvarna Automower integration. This was previously a custom integration. As there is the lawn_mower entity now, I thought it's a good moment to integrate it in Home Assistant.
Replaces messed up #99776

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Add documentation for the new Husqvarna Automower integration home-assistant.io#28817

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

robinostlund · 2023-09-19T11:28:15Z

@Thomas55555 seems to be some issues with the pytests

Thomas55555 · 2023-09-19T17:53:01Z

I've improved the tests, but they are not passing yet, because I can't handle this in the tests:

core/homeassistant/components/husqvarna_automower/__init__.py

Lines 29 to 33 in ddf94cd

    
           implementation = ( 
        
               await config_entry_oauth2_flow.async_get_config_entry_implementation( 
        
                   hass, entry 
        
               ) 
        
           )

In the previous PR, we focused on getting the code right, and the tests were blocked in the CI.
How will it be now, should I also finish the tests, or can I do this later, after I got an okay for the "normal code"?

robinostlund · 2023-09-21T05:59:47Z

@Thomas55555 just a question, this integration will be missing the calendar and all the other sensors right?

MartinHjelmare · 2023-09-21T06:06:09Z

We need to finish the tests before merging the PR, but it's ok to wait with the tests until the rest of the code is done.

homeassistant/components/husqvarna_automower/__init__.py

MartinHjelmare · 2023-09-21T06:13:00Z

homeassistant/components/husqvarna_automower/api.py

+from homeassistant.helpers import config_entry_oauth2_flow
+
+
+class AsyncConfigEntryAuth(aioautomower.AbstractAuth):


The library client should use this auth instance. It looks unused now. We just instantiate it but then don't use it.

When the library client wants to get an access token to use, ie before every request, it should use async_get_access_token defined in this class. The library doesn't seem to have been updated to allow this. I recommend reading our library guide on how to structure the library and client:

https://developers.home-assistant.io/docs/api_lib_index

I've reworked the library according to the documentation. I actually like this approach.
Everything works fine now except of the websocket connection. It's not possible to establish it and I don't get an error. I've tried very long, but wasn't able to get it working. Could you have a look at the library, please?
https://github.com/Thomas55555/aioautomower/blob/a196d9fbbff1f9fddf65a3eed3d029872ce51a00/aioautomower/session.py#L371

I don't think you should make a loop when connecting the websocket. Just have a connect method that connects the websocket and stores a reference to it on the client.

https://github.com/Thomas55555/aioautomower/blob/a196d9fbbff1f9fddf65a3eed3d029872ce51a00/aioautomower/auth.py#L148-L160

Then have another method listen that fetches incoming messages and iterates over them and handles them. It's this method that the library user should create a background task for.

https://github.com/Thomas55555/aioautomower/blob/a196d9fbbff1f9fddf65a3eed3d029872ce51a00/aioautomower/session.py#L374

The benefit of separating the connect and listen methods is that we can make sure we can connect the websocket with a timeout before we create the task that should listen for websocket messages. If we can connect the websocket the chances are high that the websocket communication will work. If we fail to connect during the timeout, we want to raise ConfigEntryNotReady and try again later automatically.

Side notes:

It looks like there's a double call to update data callbacks:
https://github.com/Thomas55555/aioautomower/blob/a196d9fbbff1f9fddf65a3eed3d029872ce51a00/aioautomower/session.py#L380-381
https://github.com/Thomas55555/aioautomower/blob/a196d9fbbff1f9fddf65a3eed3d029872ce51a00/aioautomower/session.py#L342

I'd remove the schedule immediately parameter. The library user can call the callback themselves if needed.
https://github.com/Thomas55555/aioautomower/blob/a196d9fbbff1f9fddf65a3eed3d029872ce51a00/aioautomower/session.py#L74

If we create a connect method in the library for the websocket, there should also be a disconnect method for the websocket.

There is now a close method

homeassistant/components/husqvarna_automower/config_flow.py

MartinHjelmare · 2023-09-21T06:29:18Z

homeassistant/components/husqvarna_automower/coordinator.py

+
+    async def _async_update_data(self) -> None:
+        """Fetch data from Husqvarna."""
+        await self.session.connect()


I looked at the library. It currently doesn't consistently use the aiohttp client session that is provided when instantiating the abstract auth class. The library should use that provided client session for all requests made. It's ok to create a default aiohttp client session if no session is provided by the library user.

I also suggest dropping or making optional the task that gets the status. The library user can do that. In Home Assistant we can use the update coordinator here to do that.

We can also use the coordinator and set updated data when the websocket callbacks with updated data. There's this coordinator method:

core/homeassistant/helpers/update_coordinator.py

Lines 400 to 402 in 11c4c37

@callback

def async_set_updated_data(self, data: _DataT) -> None:

"""Manually update data, notify listeners and reset refresh interval."""

Then we can remove the callback registration from the entities, and just do that in the coordinator instead. The coordinator will update all coordinator entities when the coordinator is updated.

I also suggest being consistent in the library with exceptions and logging.

Debug logging is always ok.

Errors that happen in non background tasks are preferably raised as library specific exceptions and not logged. Let the library user decide how to handle the error and if they want to log it.

In background tasks raised exceptions are not as useful, unless we make sure that the library user can handle the exception. One way to do that is to let the library user create and handle the task, ie just make a coroutine method that listens for the websocket messages and let the library user create the task for that. This way the library user can easier react to exceptions and decide how to handle them, eg re-connecting with a backoff, like what is done when Home Assistant raises ConfigEntryNotReady.

home-assistant · 2023-09-21T10:59:43Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

homeassistant/components/husqvarna_automower/__init__.py

tests/components/husqvarna_automower/test_application_credentials.py

tests/components/husqvarna_automower/test_common.py

tests/components/husqvarna_automower/test_lawn_mower.py

Thomas55555 · 2023-09-21T18:16:13Z

question, this integration will be missing the calendar and all the other sensors right?

In the beginning yes. Later I want to add additional platforms.

homeassistant/components/husqvarna_automower/coordinator.py

MartinHjelmare · 2023-09-28T18:45:59Z

homeassistant/components/husqvarna_automower/coordinator.py

-        )
+        if not self.ws_connected:
+            await self.mowersession.connect()
+            self.mowersession.register_data_callback(


If this just stores the callback reference, we probably don't need to do it after every connect call, but just once for the coordinator. Or is the callback unregistered if the connection is lost?

homeassistant/components/husqvarna_automower/lawn_mower.py

tests/components/husqvarna_automower/const.py

MartinHjelmare · 2023-10-22T22:27:21Z

tests/components/husqvarna_automower/test_lawn_mower.py

    await setup_entity(hass)
-    coordinator = hass.data[DOMAIN]["automower_test"]
-    lawn_mower = AutomowerLawnMowerEntity(mower.data[0], coordinator)
+    coordinator: AutomowerDataUpdateCoordinator = hass.data[DOMAIN]["automower_test"]


Please don't interact directly with the coordinator or any entities in tests. Those are integrations details. Set up the integration while patching the client library appropriately and assert core state.

https://developers.home-assistant.io/docs/development_testing#writing-tests-for-integrations

I've changed some of the tests in this file. Can you tell me, if this is going in the right direction?

Yes, I added some comments below.

github-actions · 2023-12-27T16:04:58Z

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

MartinHjelmare · 2023-12-27T18:13:05Z

I'm hoping we can finish this PR at some point.

Thomas55555 · 2023-12-27T19:21:55Z

I was quite busy the last months. But I was working on the library the last days.
I also hope we can finish it soon.

MartinHjelmare

The tests are mowing in the right direction. 👍

MartinHjelmare · 2024-01-03T17:35:42Z

tests/components/husqvarna_automower/test_lawn_mower.py

+            resume_schedule=AsyncMock(),
+        ),
+    ), patch(
+        "homeassistant.helpers.config_entry_oauth2_flow.async_get_config_entry_implementation",


We shouldn't need to patch all these details.

If it isn't patched, there are errors like that: FAILED tests/components/husqvarna_automower/test_lawn_mower.py::test_lawn_mower_commands - TypeError: <AsyncMock name='async_get_config_entry_implementation().async_refresh_token()' id='139843651950352'>
I don't know another way to avoid them.

tests/components/husqvarna_automower/test_lawn_mower.py

tests/components/husqvarna_automower/conftest.py

* add translations to exceptions * Make errors more user understandable * make command not ternary operator * removed non-user facing exceptions * Add user facing exceptions and code coverage * add match * fix linting * Apply suggestions from code review Co-authored-by: Franck Nijhof <frenck@frenck.nl> --------- Co-authored-by: Franck Nijhof <frenck@frenck.nl>

* Add cloud tts entity * Test test_login_view_missing_entity * Fix pipeline iteration for migration * Update tests * Make migration more strict * Fix docstring

…108034) * Add helper function to update and reload config entry to config flow * Use async_create_task * Remove await * Reload only when update & add task name * Rename function

* Cleanup Discovergy config flow * Make use of the helper function

… Watch (#108355)

Co-authored-by: Erik <erik@montnemery.com> Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

…M Fritz!Tools (#108667) prevent dictionary changed size during iteration

* Use snapshot testing in Airly sensor * Apply suggestions from code review Co-authored-by: Robert Resch <robert@resch.dev> * Fix tests --------- Co-authored-by: Robert Resch <robert@resch.dev>

* Add icon translations to Airly * Fix test * Fix tests

* Fixing foot warmer timer bug * Fixing bug where temperature wasnt assigned to number entity causing tests to fail

home-assistant

Hello @Thomas55555,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

6b597ac2607dc679b7950f29377cc9fc631bf27d - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.
2d59d507e5025d964459b2105d06cd4f60fe75ec - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting "Author Name" and "email@address.com" for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

* Add time to charge and type checking * Revert drive_state_shift_state change * Use original name * Use function instead of lambda * Update homeassistant/components/tessie/sensor.py Co-authored-by: Jan-Philipp Benecke <github@bnck.me> * Fix callback * Avoid having to test None * Go back to if * Use minutes instead of hours --------- Co-authored-by: Jan-Philipp Benecke <github@bnck.me>

home-assistant

Hello @Thomas55555,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

6b597ac2607dc679b7950f29377cc9fc631bf27d - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.
2d59d507e5025d964459b2105d06cd4f60fe75ec - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting "Author Name" and "email@address.com" for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

This reverts commit 45d8d1f, reversing changes made to bacbc9b.

home-assistant

Hello @Thomas55555,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

6b597ac2607dc679b7950f29377cc9fc631bf27d - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.
2d59d507e5025d964459b2105d06cd4f60fe75ec - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting "Author Name" and "email@address.com" for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

This reverts commit c1148fe.

home-assistant

Hello @Thomas55555,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

6b597ac2607dc679b7950f29377cc9fc631bf27d - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.
2d59d507e5025d964459b2105d06cd4f60fe75ec - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting "Author Name" and "email@address.com" for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

…omower

home-assistant

Hello @Thomas55555,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

6b597ac2607dc679b7950f29377cc9fc631bf27d - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.
2d59d507e5025d964459b2105d06cd4f60fe75ec - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting "Author Name" and "email@address.com" for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

home-assistant

Hello @Thomas55555,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

6b597ac2607dc679b7950f29377cc9fc631bf27d - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.
2d59d507e5025d964459b2105d06cd4f60fe75ec - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.
e0fda6ef79613e4d5a9518cb747d8144d29a5317 - This commit has something that looks like an email address (thomas.protzner@gmai.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
```
git commit --amend --author="Author Name <email@address.com>"
```
  (substituting "Author Name" and "email@address.com" for your actual information) to set the authorship information.
- If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
  1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
  2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

home-assistant bot added cla-signed has-tests integration: husqvarna_automower new-integration labels Sep 18, 2023

Thomas55555 changed the title ~~Automower~~ Add Husqvarna Automower integration Sep 18, 2023

This was referenced Sep 18, 2023

Add documentation for the new Husqvarna Automower integration home-assistant/home-assistant.io#28817

Merged

Move Husqvanra Automower branding images from custom to core home-assistant/brands#4655

Merged

Thomas55555 marked this pull request as ready for review September 18, 2023 21:58

MartinHjelmare requested changes Sep 21, 2023

View reviewed changes

home-assistant bot marked this pull request as draft September 21, 2023 10:59

MartinHjelmare reviewed Sep 21, 2023

View reviewed changes

MartinHjelmare reviewed Sep 28, 2023

View reviewed changes

homeassistant/components/husqvarna_automower/coordinator.py Outdated Show resolved Hide resolved

MartinHjelmare reviewed Sep 28, 2023

View reviewed changes

MartinHjelmare requested changes Oct 17, 2023

View reviewed changes

homeassistant/components/husqvarna_automower/lawn_mower.py Outdated Show resolved Hide resolved

tests/components/husqvarna_automower/const.py Outdated Show resolved Hide resolved

MartinHjelmare reviewed Oct 22, 2023

View reviewed changes

github-actions bot added the stale label Dec 27, 2023

github-actions bot removed the stale label Dec 27, 2023

MartinHjelmare reviewed Jan 3, 2024

View reviewed changes

MartinHjelmare reviewed Jan 4, 2024

View reviewed changes

tests/components/husqvarna_automower/conftest.py Outdated Show resolved Hide resolved

tests/components/husqvarna_automower/conftest.py Outdated Show resolved Hide resolved

tests/components/husqvarna_automower/conftest.py Outdated Show resolved Hide resolved

MartinHjelmare self-assigned this Jan 4, 2024

MartinHjelmare and others added 11 commits January 22, 2024 17:24

Add cloud tts entity (#108293)

1e5a5e5

* Add cloud tts entity * Test test_login_view_missing_entity * Fix pipeline iteration for migration * Update tests * Make migration more strict * Fix docstring

Add helper function to update and reload config entry to config flow (#…

01fb44e

…108034) * Add helper function to update and reload config entry to config flow * Use async_create_task * Remove await * Reload only when update & add task name * Rename function

Cleanup Discovergy config flow (#108381)

acb3123

* Cleanup Discovergy config flow * Make use of the helper function

Update iOS configuration adding Action toggles to show in CarPlay and…

d815935

… Watch (#108355)

Move core fundamental components into bootstrap (#105560)

30d8c3e

Co-authored-by: Erik <erik@montnemery.com> Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

Prevent runtime issue during entity registration in coordinator of AV…

3f6ce42

…M Fritz!Tools (#108667) prevent dictionary changed size during iteration

tests

384d242

Use snapshot testing in Airly sensor (#108608)

abb1d68

* Use snapshot testing in Airly sensor * Apply suggestions from code review Co-authored-by: Robert Resch <robert@resch.dev> * Fix tests --------- Co-authored-by: Robert Resch <robert@resch.dev>

Add icon translations to Airly (#108404)

e0302c3

* Add icon translations to Airly * Fix test * Fix tests

Fix SleepIQ setting FootWarmer timer (#108433)

dfca9d4

* Fixing foot warmer timer bug * Fixing bug where temperature wasnt assigned to number entity causing tests to fail

tests

bacbc9b

home-assistant bot requested changes Jan 22, 2024

View reviewed changes

home-assistant bot added the cla-error label Jan 22, 2024

Bre77 and others added 3 commits January 22, 2024 21:45

Fix flaky sensibo test (#108669)

cef444c

Merge branch 'dev' into automower

45d8d1f

home-assistant bot requested changes Jan 22, 2024

View reviewed changes

Revert "Merge branch 'dev' into automower"

c1148fe

This reverts commit 45d8d1f, reversing changes made to bacbc9b.

home-assistant bot requested changes Jan 22, 2024

View reviewed changes

Thomas55555 added 2 commits January 22, 2024 22:13

Revert "Revert "Merge branch 'dev' into automower""

10e65d7

This reverts commit c1148fe.

Revert "Revert "Merge branch 'dev' into automower""

c32a767

home-assistant bot requested changes Jan 22, 2024

View reviewed changes

Thomas55555 added 2 commits January 22, 2024 22:22

Revert "Revert "Merge branch 'dev' into automower""

1b56604

Merge remote-tracking branch 'refs/remotes/origin/automower' into aut…

bcc00d8

…omower

home-assistant bot requested changes Jan 22, 2024

View reviewed changes

Thomas55555 and others added 2 commits January 23, 2024 11:47

tests

023229c

tests

09894ec

home-assistant bot requested changes Jan 23, 2024

View reviewed changes

Thomas55555 closed this Jan 23, 2024

github-actions bot locked and limited conversation to collaborators Jan 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Husqvarna Automower integration #100569

Add Husqvarna Automower integration #100569

Thomas55555 commented Sep 18, 2023

robinostlund commented Sep 19, 2023

Thomas55555 commented Sep 19, 2023 •

edited

Loading

robinostlund commented Sep 21, 2023 •

edited

Loading

MartinHjelmare commented Sep 21, 2023

MartinHjelmare Sep 21, 2023

Thomas55555 Oct 12, 2023

MartinHjelmare Oct 12, 2023

MartinHjelmare Oct 12, 2023

Thomas55555 Jan 3, 2024

MartinHjelmare Sep 21, 2023 •

edited

Loading

home-assistant bot commented Sep 21, 2023

Thomas55555 commented Sep 21, 2023

MartinHjelmare Sep 28, 2023

MartinHjelmare Oct 22, 2023 •

edited

Loading

Thomas55555 Jan 3, 2024

MartinHjelmare Jan 3, 2024

github-actions bot commented Dec 27, 2023

MartinHjelmare commented Dec 27, 2023 •

edited

Loading

Thomas55555 commented Dec 27, 2023

MartinHjelmare left a comment

MartinHjelmare Jan 3, 2024

Thomas55555 Jan 4, 2024

home-assistant bot left a comment

home-assistant bot left a comment

home-assistant bot left a comment

home-assistant bot left a comment

home-assistant bot left a comment

home-assistant bot left a comment

		from homeassistant.helpers import config_entry_oauth2_flow


		class AsyncConfigEntryAuth(aioautomower.AbstractAuth):

	@callback
	def async_set_updated_data(self, data: _DataT) -> None:
	"""Manually update data, notify listeners and reset refresh interval."""

Add Husqvarna Automower integration #100569

Add Husqvarna Automower integration #100569

Conversation

Thomas55555 commented Sep 18, 2023

Breaking change

Proposed change

Type of change

Additional information

Checklist

robinostlund commented Sep 19, 2023

Thomas55555 commented Sep 19, 2023 • edited Loading

robinostlund commented Sep 21, 2023 • edited Loading

MartinHjelmare commented Sep 21, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MartinHjelmare Sep 21, 2023 • edited Loading

Choose a reason for hiding this comment

home-assistant bot commented Sep 21, 2023

Thomas55555 commented Sep 21, 2023

Choose a reason for hiding this comment

MartinHjelmare Oct 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 27, 2023

MartinHjelmare commented Dec 27, 2023 • edited Loading

Thomas55555 commented Dec 27, 2023

MartinHjelmare left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

home-assistant bot left a comment

Choose a reason for hiding this comment

home-assistant bot left a comment

Choose a reason for hiding this comment

home-assistant bot left a comment

Choose a reason for hiding this comment

home-assistant bot left a comment

Choose a reason for hiding this comment

home-assistant bot left a comment

Choose a reason for hiding this comment

home-assistant bot left a comment

Choose a reason for hiding this comment

Thomas55555 commented Sep 19, 2023 •

edited

Loading

robinostlund commented Sep 21, 2023 •

edited

Loading

MartinHjelmare Sep 21, 2023 •

edited

Loading

MartinHjelmare Oct 22, 2023 •

edited

Loading

MartinHjelmare commented Dec 27, 2023 •

edited

Loading