Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HitachiAirToAirHeatPump (hlrrwifi:HLinkMainController) in Overkiz #103803

Merged

Conversation

dotvav
Copy link
Contributor

@dotvav dotvav commented Nov 11, 2023

Proposed change

Add support for the HitachiAirToAirHeatPump (hlrrwifi:HLinkMainController) climate entity, ported from
https://github.com/iMicknl/ha-tahoma/blob/master/custom_components/tahoma/climate_devices/hitachi_air_to_air_heat_pump.py.

Fixes #85781

This PR is a continuation of @Micknl's work #81743 and a reset of a previously open PR on a messed up branch #95706.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict.

@home-assistant
Copy link

Hey there @iMicknl, @vlebourl, @tetienne, @nyroDev, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of overkiz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign overkiz Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@dotvav dotvav marked this pull request as ready for review November 11, 2023 17:44
@dotvav dotvav requested a review from iMicknl as a code owner November 11, 2023 17:44
@dotvav
Copy link
Contributor Author

dotvav commented Nov 11, 2023

Apologies to the reviewers of #95706 I had to recreate this PR in a new branch because I have messed up the other one.

@iMicknl iMicknl dismissed home-assistant’s stale review November 21, 2023 18:13

Merge issue resolved.

@iMicknl iMicknl changed the title Support HLRRWIFI Hitachi heat pumps Support HitachiAirToAirHeatPump (hlrrwifi:HLinkMainController) in Overkiz Nov 21, 2023
Copy link
Contributor

@iMicknl iMicknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very complex device unfortunately, but seems handled fine and you have tested it yourself.

(all comments on previous PR have been addressed)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 23, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dotvav 👍

../Frenck

@frenck frenck merged commit a1701f0 into home-assistant:dev Nov 24, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2023
@dotvav dotvav deleted the overkiz-hitachi-air-heat-pump-hlrrwifi branch November 25, 2023 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: overkiz new-feature Quality Scale: No score smash Indicator this PR is close to finish for merging or closing
Projects
None yet
3 participants