Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mysensors updates and platform setup async #13603

Merged
merged 1 commit into from Apr 1, 2018
Merged

Make mysensors updates and platform setup async #13603

merged 1 commit into from Apr 1, 2018

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Apr 1, 2018 •
edited

Description:

  • Use async updates but keep methods that interact with mysensors gateway thread, eg turn_on and turn_off, non async. The update methods can easily be converted to async as they are only interacting with dictionaries.
  • Use Python 3.5 async syntax.
  • A full async conversion will follow later.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@MartinHjelmare
Make mysensors updates and platform setup async
9e94d2a 
* Use async updates but keep methods that interact with mysensors
  gateway thread, eg turn_on and turn_off, non async.
* Use Python 3.5 async syntax.
@balloob balloob merged commit c8f2810 into home-assistant:dev Apr 1, 2018
mountainsandcode added a commit to mountainsandcode/home-assistant that referenced this pull request Apr 2, 2018
@mountainsandcode
Merge branch 'dev' of https://github.com/home-assistant/home-assistant …
dfb65d9 
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant: (43 commits)
  Upgrade py-cpuinfo to 4.0.0 (home-assistant#13629)
  changed PyTado version (home-assistant#13626)
  Hue mireds value is actually 153 not 154 (home-assistant#13601)
  Version bump to 0.66.1
  Fix mysensors sensor type lookup (home-assistant#13574)
  Add pincode fallback (home-assistant#13587)
  Fix mqtt_json color commands (home-assistant#13617)
  Fix mqtt_json color commands (home-assistant#13617)
  Bugfix for tradfri to correctly execute Command. (home-assistant#13618)
  Fix Hue error logging (home-assistant#13616)
  Add pincode fallback (home-assistant#13587)
  Use 0/1 for raspberry pi cover GPIO writes rather than true/false (home-assistant#13610)
  Make mysensors updates and platform setup async (home-assistant#13603)
  Unflake folder watcher test (home-assistant#13569)
  Re-add group polling as a fallback for observation (home-assistant#13613)
  Fix IMAP email message_data (home-assistant#13606)
  Broadlink (home-assistant#13585)
  Version bump frontend done right
  Fix mysensors update callback (home-assistant#13602)
  Version bump to 0.66.1b0
  ...
@MartinHjelmare MartinHjelmare deleted the add-mysensors-async-update branch April 2, 2018 15:49
@balloob balloob mentioned this pull request Apr 13, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MartinHjelmare @balloob @homeassistant