Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and use bunch of data size and rate related constants #31781

merged 1 commit into from Feb 13, 2020


Copy link

scop commented Feb 13, 2020

Proposed change

Add bunch of units to use for data sizes and rates. We stay consistent easier by using these.

Also fix a few units to match the corresponding data.

Will add some more general use ones, probably time related, in a separate followup PR later.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: #29552 and #31543
  • Link to documentation pull request:


  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
Also fix a few units to match the corresponding data.
@scop scop requested review from fabaff, frenck, rohankapoorcom and home-assistant/core as code owners Feb 13, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 13, 2020
Dev automation moved this from Needs review to Reviewer approved Feb 13, 2020
Copy link

springstan left a comment

LGTM 鉁 really nice improvement to the code quality!

@balloob balloob merged commit 3e23a3a into home-assistant:dev Feb 13, 2020
11 checks passed
11 checks passed
CI Build #20200213.9 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.66%)
codecov/project 94.67% (target 90%)
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 13, 2020
@scop scop deleted the scop:units branch Feb 13, 2020
Quentame added a commit to Quentame/home-assistant that referenced this pull request Feb 14, 2020
@lock lock bot locked and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.