Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi select support to config validation and to custom serializer #31798

Merged

Conversation

@Kane610
Copy link
Member

Kane610 commented Feb 13, 2020

Breaking change

Proposed change

This adds backend support to previously opened PR to frontend by Bram.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@Kane610 Kane610 requested review from balloob and bramkragten Feb 13, 2020
@Kane610 Kane610 requested a review from home-assistant/core as a code owner Feb 13, 2020
@Kane610 Kane610 self-assigned this Feb 13, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 13, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #31798 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #31798   +/-   ##
=======================================
  Coverage   94.67%   94.68%           
=======================================
  Files         763      763           
  Lines       55126    55148   +22     
=======================================
+ Hits        52192    52215   +23     
+ Misses       2934     2933    -1     
Impacted Files Coverage 螖
homeassistant/components/simplisafe/const.py 100.00% <0.00%> (酶) 猬嗭笍
homeassistant/components/template/cover.py 97.71% <0.00%> (+1.36%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9e7185c...0823496. Read the comment docs.

Dev automation moved this from Needs review to Reviewer approved Feb 13, 2020
@balloob balloob merged commit 6211a2b into home-assistant:dev Feb 13, 2020
10 of 11 checks passed
10 of 11 checks passed
codecov/patch 81.81% of diff hit (target 94.67%)
Details
CI Build #20200213.50 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.68% (target 90.00%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 13, 2020
@Kane610 Kane610 deleted the Kane610:config_validation-multi_select_support branch Feb 14, 2020
@bramkragten

This comment has been minimized.

Copy link
Member

bramkragten commented Feb 14, 2020

Might be doing something wrong, but I get errors trying this:

    data["data_schema"] = voluptuous_serialize.convert(schema)
  File "/Users/bram/Documents/projects/home-assistant/home-assistant/venv/lib/python3.7/site-packages/voluptuous_serialize/__init__.py", line 38, in convert
    pval = convert(value, custom_serializer=custom_serializer)
  File "/Users/bram/Documents/projects/home-assistant/home-assistant/venv/lib/python3.7/site-packages/voluptuous_serialize/__init__.py", line 108, in convert
    raise ValueError('Unable to convert schema: {}'.format(schema))
ValueError: Unable to convert schema: <function multi_select.<locals>.validator at 0x11682b4d0>

With:

            data_schema=vol.Schema(
                {
                    vol.Optional("test"): cv.multi_select({"paulus": "Paulus", "robban": "Robban"}),
                }
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 14, 2020

Oh right 馃う鈥嶁檪 multi_select returns a local function that we try to compare to multi_select, which is obviously not true

We should probably make MultiSelect a class with a __call__ so that we can do isinstance.

class multi_select:
    def __init__(options)
    def __call__(value)
@Kane610 Kane610 mentioned this pull request Feb 14, 2020
7 of 20 tasks complete
@Kane610

This comment has been minimized.

Copy link
Member Author

Kane610 commented Feb 14, 2020

@balloob @bramkragten something like this? #31828

@jjlawren jjlawren mentioned this pull request Feb 15, 2020
8 of 20 tasks complete
@lock lock bot locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.