Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change multi_select config validator to class #31828

Merged

Conversation

@Kane610
Copy link
Member

Kane610 commented Feb 14, 2020

Breaking change

Proposed change

Following discussion in #31798

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: #31798
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@Kane610 Kane610 requested review from balloob and bramkragten Feb 14, 2020
@Kane610 Kane610 requested a review from home-assistant/core as a code owner Feb 14, 2020
@Kane610 Kane610 self-assigned this Feb 14, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 14, 2020
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 14, 2020

You need to update the serializer too, and please also add a test for the serializer.

@Kane610

This comment has been minimized.

Copy link
Member Author

Kane610 commented Feb 14, 2020

@balloob done

Dev automation moved this from Needs review to Reviewer approved Feb 14, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #31828 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31828      +/-   ##
==========================================
+ Coverage   94.65%   94.66%   +<.01%     
==========================================
  Files         763      763              
  Lines       55160    55164       +4     
==========================================
+ Hits        52213    52221       +8     
+ Misses       2947     2943       -4
Impacted Files Coverage 螖
homeassistant/helpers/config_validation.py 95.92% <100%> (+0.26%) 猬嗭笍
...stant/components/homekit_controller/config_flow.py 100% <0%> (酶) 猬嗭笍
homeassistant/components/coolmaster/config_flow.py 100% <0%> (酶) 猬嗭笍
homeassistant/components/esphome/config_flow.py 100% <0%> (酶) 猬嗭笍
homeassistant/helpers/restore_state.py 98.44% <0%> (+0.01%) 猬嗭笍
homeassistant/helpers/entity_component.py 96.82% <0%> (+0.02%) 猬嗭笍
homeassistant/components/template/cover.py 97.71% <0%> (+1.36%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 71a81c4...1724350. Read the comment docs.

@balloob balloob merged commit 043d36f into home-assistant:dev Feb 14, 2020
10 checks passed
10 checks passed
CI Build #20200214.52 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.65%)
Details
codecov/project 94.66% (+<.01%) compared to 71a81c4
Details
Dev automation moved this from Reviewer approved to Done Feb 14, 2020
@Kane610 Kane610 deleted the Kane610:config_validation-multi_select_to_class branch Feb 14, 2020
@jjlawren

This comment has been minimized.

Copy link
Contributor

jjlawren commented Feb 15, 2020

Very possible I'm missing something on my side, but I'm not able to get this work. Slightly different error from the comment in the previous case.

data_schema=vol.Schema(
    {
        vol.Optional("users"): cv.multi_select(
            {"user1": "user1", "user2": "user2"}
        ),
    }
)
  File "/home/homeassistant/src/home-assistant/venv/lib/python3.7/site-packages/voluptuous_serialize/__init__.py", line 108, in convert
    raise ValueError('Unable to convert schema: {}'.format(schema))
ValueError: Unable to convert schema: <homeassistant.helpers.config_validation.multi_select object at 0x7ff1b7771050>
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 15, 2020

Where are you serializing it? The serializer needs to reference the custom serializer to work.

@jjlawren jjlawren mentioned this pull request Feb 15, 2020
6 of 20 tasks complete
@lock lock bot locked and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.