-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tado weather support #44807
Add Tado weather support #44807
Conversation
Hey there @michaelarnauts, @bdraco, mind taking a look at this pull request as its been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
Left some small comments. Overall looks good though. Looking forward to the change getting in!
@Noltari I'm sorry, I don't mean to dismiss your work, but why would you want to add this to the Tado integration? |
I looked this over and it looked good to my eyes. I did notice that you have a humidity method that seems unnecessary, but you are forced by the underlying integration to implement it. I created a PR #45095 to address this. |
@bouwew You're right, but it may be interesting to access Tado weather data, since this is used by Tado to decide if your heating is powered on or not. |
@MatthewFlamm Yes, there's no way to get rid of humidity, since it's required by Home Assistant's Weather Entity. |
@Noltari You could add the "values of interest" as sensors that are placed under the Tado hub, or whatever it's called. |
I've just noticed in the mentioned architecture PR that the provided weather data is very limited. Isn't it much simpler and quicker to add 3 sensors instead of adding a full weather implementation? |
@bouwew I added a new commit exporting the weather data as normal sensors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick glance over and most things look okey.
This change was suggested by @elupus: home-assistant#44807 (comment) Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Given the direction of the arch issue, I'd like to get a second opinion before merging: #44807 (comment) |
This change was suggested by @elupus: home-assistant#44807 (comment) Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Hey @MartinHjelmare, would you mind giving a second opinion about this? |
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Also improve init to avoid calling getMe twice. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
This change was suggested by @elupus: home-assistant#44807 (comment) Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Only sensors will be exposed until a decission regarding the lack of humidity is made. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@bdraco @MartinHjelmare rebased on latest dev branch and removed usage of weather constants. |
Will retest shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed change
Add weather support for the Tado integration.
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: