Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Geizhals integration (ADR-0004) #48594

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Apr 1, 2021

Breaking change

The Geizhals integration has been removed from Home Assistant because it relies on web scraping, which is no longer allowed.

Proposed change

While reviewing PR #48593, I've noticed the upstream package actually relies on web scraping:

https://github.com/JulianKahnert/geizhals/blob/31405b2afc416940f34a211e1e64ed165b11dec4/geizhals/geizhals.py#L80-L86

This violated ADR-0004: https://github.com/home-assistant/architecture/blob/master/adr/0004-webscraping.md

Additionally, the upstream package has been archived. The suggested replacement package in #48593 relies on web scraping as well (and thus has been declined).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare merged commit e76503d into dev Apr 1, 2021
@MartinHjelmare MartinHjelmare deleted the frenck-2021-1019 branch April 1, 2021 22:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geizhals Integration
3 participants