Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for logger info in fronius integration #54795

Merged
merged 5 commits into from
Aug 22, 2021

Conversation

nielstron
Copy link
Contributor

@nielstron nielstron commented Aug 18, 2021

Breaking change

Proposed change

This adds the option to track the costs and returns of energy of the fronius inverter.
The newly added sensors "cash factor" and "delivery factor" track the current price for bought and sold energy in currency/kWh.

This is a feature of a newer version of pyfronius and hence requires a dependency upgrade.

New Release: https://github.com/nielstron/pyfronius/releases/tag/release-0.6.0

Diff: nielstron/pyfronius@release-0.5.5...release-0.6.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

This adds the option to track the costs and returns of energy of the fronius inverter
@nielstron nielstron changed the title Add support for logger info Add support for logger info in fronius integration Aug 18, 2021
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When bumping a requirement, add a link to the release and of diff for that requirement to the PR description 👍

@nielstron
Copy link
Contributor Author

Sorry :) Diff/Release page added

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 18, 2021
homeassistant/components/fronius/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/fronius/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/fronius/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/fronius/sensor.py Outdated Show resolved Hide resolved
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Aug 21, 2021
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nielstron 👍

@frenck frenck merged commit 6d049c7 into home-assistant:dev Aug 22, 2021
raman325 added a commit to raman325/home-assistant that referenced this pull request Aug 22, 2021
* upstream/dev: (52 commits)
  Add zigbee connection for wemo bridge lights (home-assistant#53813)
  Use EntityDescription - ring (home-assistant#55023)
  Add support for bridge accessory unavailability (home-assistant#52207)
  Fix P1 Monitor requirement in manifest (home-assistant#55027)
  Improve device trigger type hinting (home-assistant#54907)
  Use EntityDescription - openuv (home-assistant#55022)
  Add silver quality scale to goalzero (home-assistant#53299)
  Add Binary Sensor for WeMo Insight & Maker (home-assistant#55000)
  Add state_class to relevant sensors in Danfoss Air (home-assistant#54847)
  Remove base_test from modbus test harness (home-assistant#55018)
  Add support for logger info in fronius integration (home-assistant#54795)
  Skip trying the pyudev observer when using standalone docker for usb (home-assistant#54987)
  Upgrade watchdog to 2.1.4 (home-assistant#54993)
  Upgrade apprise to 0.9.4 (home-assistant#55002)
  Fix incorrect power device class on energy sensors in Smappee (home-assistant#54994)
  Add missing BYN currency (home-assistant#55001)
  Fix manual setup when roomba is on different subnet (home-assistant#54639)
  [ci skip] Translation update
  Bump python-yeelight to 0.7.3 (home-assistant#54982)
  Upgrade PyTurboJPEG to 1.5.2 (home-assistant#54992)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants