Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mystrom power & temperature #23753

Closed
wants to merge 7 commits into from
Closed

Conversation

softplus
Copy link

Show how to use the REST API to get power & temperature for the mystrom switches. Technically it's not a part of the current integration, and should be updated once the pull request home-assistant/core#69745 is live.

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

microraptor and others added 7 commits August 11, 2022 00:23
Co-authored-by: J. Nick Koston <nick@koston.org>
Show how to use the REST API to get power & temperature for the mystrom switches. Technically it's not a part of the current integration, and should be updated once the pull request home-assistant/core#69745 is live.
@softplus softplus requested a review from fabaff as a code owner August 13, 2022 12:33
@probot-home-assistant probot-home-assistant bot added the has-parent This PR has a parent PR in a other repo label Aug 13, 2022
@homeassistant
Copy link

Hi @softplus,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Aug 13, 2022
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Aug 13, 2022
@probot-home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.
(message by DocsTargetBranch)

@softplus softplus changed the base branch from current to next August 13, 2022 12:47
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you already stated, this is not part of this integration and should therefore not be documented here as such either.

Things like these can be put up in the community guides section on our community forums.

Thanks for being willing to contribute though 👍

../Frenck

@frenck frenck closed this Aug 15, 2022
@probot-home-assistant probot-home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Aug 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2022
@softplus softplus deleted the patch-1 branch September 3, 2022 22:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants