-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support password less PI-Hole installations #86183
Support password less PI-Hole installations #86183
Conversation
Hey there @johnluetke, @shenxn, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I just put the word “none” in the field for the API and it proceeded just fine. |
yes it works, but it is much more user friendly, to only be asked for entering an api key when necessary |
I'll put this in draft until the PR targeting dev is approved as this PR will need mostly the same code. |
Wrong button caused by the UI jumping a bit during the page load :( Sorry about that. |
c6c8ca2
to
46ccc41
Compare
The failing pip-check is expected as this is the RC branch. |
Proposed change
With this, the config flow does recognize if an API key is needed or not.
This is targeted against
rc
because of #85264 (comment)Another PR, based on and targeted to
dev
will follow in a few moments (#86184)Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: