Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support password less PI-Hole installations #86183

Merged

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Jan 18, 2023

Proposed change

With this, the config flow does recognize if an API key is needed or not.


This is targeted against rc because of #85264 (comment)
Another PR, based on and targeted to dev will follow in a few moments (#86184)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@mib1185 mib1185 added this to the 2023.1.6 milestone Jan 18, 2023
@home-assistant home-assistant bot added bugfix cla-signed integration: pi_hole merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. Quality Scale: No score labels Jan 18, 2023
@home-assistant
Copy link

Hey there @johnluetke, @shenxn, mind taking a look at this pull request as it has been labeled with an integration (pi_hole) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of pi_hole can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign pi_hole Removes the current integration label and assignees on the issue, add the integration domain after the command.

@zSprawl
Copy link

zSprawl commented Jan 18, 2023

I just put the word “none” in the field for the API and it proceeded just fine.

@mib1185
Copy link
Contributor Author

mib1185 commented Jan 18, 2023

I just put the word “none” in the field for the API and it proceeded just fine.

yes it works, but it is much more user friendly, to only be asked for entering an api key when necessary

@MartinHjelmare
Copy link
Member

I'll put this in draft until the PR targeting dev is approved as this PR will need mostly the same code.

@MartinHjelmare MartinHjelmare marked this pull request as draft January 18, 2023 23:24
@balloob balloob modified the milestones: 2023.1.6, 2023.1.7 Jan 20, 2023
@MartinHjelmare MartinHjelmare marked this pull request as ready for review January 20, 2023 12:02
@frenck frenck closed this Jan 22, 2023
@frenck frenck reopened this Jan 22, 2023
@frenck
Copy link
Member

frenck commented Jan 22, 2023

Wrong button caused by the UI jumping a bit during the page load :( Sorry about that.

@frenck frenck force-pushed the pi_hole/support-password-less-setups branch from c6c8ca2 to 46ccc41 Compare January 22, 2023 15:55
@frenck
Copy link
Member

frenck commented Jan 22, 2023

The failing pip-check is expected as this is the RC branch.

@frenck frenck merged commit e0d0dc0 into home-assistant:rc Jan 22, 2023
@frenck frenck mentioned this pull request Jan 22, 2023
@mib1185 mib1185 deleted the pi_hole/support-password-less-setups branch January 22, 2023 16:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cherry-picked cla-signed integration: pi_hole merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. Quality Scale: No score
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants