-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make API key mandatory for PI-Hole #85264
Conversation
Hey there @johnluetke, @shenxn, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm unable to cherry-pick this PR due to it being created on top of #84803, which is a breaking change and should not be picked into a hot fix. If you want this fix in a hot fix, open a new PR with the change against |
Proposed change
Since pi-hole version 5.18, the API key is mandatory (home-assistant-ecosystem/python-hole#13) for every api call. This has been implemented with #84516 in HA, but the config flow was never adjusted accordingly and no config entry migration has been done.
This PR will remove the config option
CONF_STATISTICS_ONLY
which was the condition if user is asked for api key or not.Further
CONF_STATISTICS_ONLY
is now removed from any existing configuration entry and a missingCONF_API_KEY
will start the reauth flow (yes it is a new feature, but it is a requirement for this bug fix).With this it is ensured, that every PI-Hole configuration entry has a valid api key.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: