Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump asyncsleepiq to 1.3.5 #92759

Merged
merged 1 commit into from
May 7, 2023
Merged

Conversation

kbickar
Copy link
Contributor

@kbickar kbickar commented May 7, 2023

Proposed change

Update asyncsleepiq lib to 1.3.5: https://github.com/kbickar/asyncsleepiq/releases/tag/v1.3.5

Fixes typing error when setting sleep number on some models

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented May 7, 2023

Hey there @mfugate1, mind taking a look at this pull request as it has been labeled with an integration (sleepiq) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sleepiq can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sleepiq Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kbickar 👍

../Frenck

@frenck frenck added this to the 2023.5.3 milestone May 7, 2023
@frenck frenck merged commit 86e5efd into home-assistant:dev May 7, 2023
@pickerin
Copy link

pickerin commented May 7, 2023

You guys rock so hard, thank you!

@kbickar kbickar deleted the sleepiq-92718 branch May 7, 2023 23:45
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sleep IQ Integration error with setting values
4 participants