Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for network mounts #16357

Merged
merged 7 commits into from
May 8, 2023
Merged

Add UI for network mounts #16357

merged 7 commits into from
May 8, 2023

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented May 1, 2023

Proposed change

Adds UI for the APIs that where added in home-assistant/supervisor#4269

Spoilers

No more will be provided.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@matthiasdebaat
Copy link
Collaborator

Great feature! One suggestion: can we move the 'move data disk' and 'add network link' buttons from the overflow menu to the bottom of the map? As we have for example on the hardware page. This makes it more findable.

bramkragten
bramkragten previously approved these changes May 2, 2023
@piitaya
Copy link
Member

piitaya commented May 2, 2023

Great!
During frontend meeting, we suggest "Network storage" instead of "Network mount" for the naming. What do you think?

@ludeeus
Copy link
Member Author

ludeeus commented May 2, 2023

Both are technical 🤷‍♂️

src/translations/en.json Outdated Show resolved Hide resolved
src/translations/en.json Outdated Show resolved Hide resolved
src/translations/en.json Outdated Show resolved Hide resolved
ludeeus and others added 3 commits May 3, 2023 09:02
Co-authored-by: Franck Nijhof <git@frenck.dev>
@bramkragten bramkragten merged commit 36a87da into dev May 8, 2023
@bramkragten bramkragten deleted the mounts branch May 8, 2023 08:18
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants