Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ecobee documentation #14230

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Update Ecobee documentation #14230

merged 3 commits into from
Aug 13, 2020

Conversation

hudcap
Copy link
Contributor

@hudcap hudcap commented Aug 11, 2020

Proposed change

Add Ecobee documentation for services added in home-assistant/core#38749

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Adds documentation for services added in home-assistant/core#38749
@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Aug 11, 2020
@frenck frenck added this to To Do in New documentation via automation Aug 13, 2020
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration parent-merged The parent PR has been merged already labels Aug 13, 2020
@project-bot project-bot bot moved this from To Do to Parent Merged in New documentation Aug 13, 2020
source/_integrations/ecobee.markdown Outdated Show resolved Hide resolved
source/_integrations/ecobee.markdown Outdated Show resolved Hide resolved
source/_integrations/ecobee.markdown Outdated Show resolved Hide resolved
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Aug 13, 2020
@project-bot project-bot bot moved this from Parent Merged to In Progress in New documentation Aug 13, 2020
Entity ID is optional, as an area could be targeted instead.

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@hudcap
Copy link
Contributor Author

hudcap commented Aug 13, 2020

Fixed, thanks!
For my own understanding, how would an area be targeted with these services?

@hudcap hudcap requested a review from frenck August 13, 2020 14:08
@hudcap
Copy link
Contributor Author

hudcap commented Aug 13, 2020

For my own understanding, how would an area be targeted with these services?

Ah, using area_id -- never came across that before.
Should that be included in the docs? Or is it understood that area_id is always a drop-in for entity_id?

@frenck
Copy link
Member

frenck commented Aug 13, 2020

It is not always a drop in for entity_id, as not all services use the new registration methods.

area_id isn't documented, because at this point, it is only usable from the automation editor in the UI. Hopefully we can change that in the future. Nevertheless, if one would make an automation in the UI, parts of the saved automation can of course manually be reused (and reveals the area ID)

New documentation automation moved this from In Progress to Awaiting Parent PR Aug 13, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating and the PR! 👍

@frenck frenck merged commit f44abce into home-assistant:next Aug 13, 2020
New documentation automation moved this from Awaiting Parent PR to Done Aug 13, 2020
@probot-home-assistant probot-home-assistant bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Aug 13, 2020
@hudcap hudcap deleted the patch-1 branch August 13, 2020 17:11
brg468 pushed a commit to brg468/home-assistant.io that referenced this pull request Aug 17, 2020
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
epenet pushed a commit to epenet/home-assistant.io that referenced this pull request Sep 8, 2020
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants