Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ecobee services #38749

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Add Ecobee services #38749

merged 1 commit into from
Aug 11, 2020

Conversation

hudcap
Copy link
Contributor

@hudcap hudcap commented Aug 11, 2020

Enable/disable automatic daylight savings time
Enable/disable the Alexa mic on the Ecobee 4
Enable/disable Smart Home/Away and follow me modes

Proposed change

This enables additional services for the Ecobee.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

I did not add tests since a) that looked daunting, and b) there were other Ecobee services that didn't have tests.
However, I did manually test all the added services on my existing HA installation and they all worked properly on my Ecobee.
I can probably figure out how to add tests if necessary.

Checklist

"Local tests pass" -- are these the tests that will run automatically after creating the PR?
Sorry for my ignorance -- I'm comfortable in Python, but I mainly write my own code, so all these guidelines and formats sound awesome, but are a little overwhelming :)

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist (I think so...)
  • The code has been formatted using Black (black --fast homeassistant tests) (formatted using Black in VSCode -- not sure what to make of that command)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Enable/disable automatic daylight savings time
Enable/disable the Alexa mic on the Ecobee 4
Enable/disable Smart Home/Away and follow me modes
@homeassistant
Copy link
Contributor

Hi @hudcap,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @marthoc, mind taking a look at this pull request as its been labeled with an integration (ecobee) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :) great first contribution!

@balloob balloob merged commit bd3f075 into home-assistant:dev Aug 11, 2020
@frenck
Copy link
Member

frenck commented Aug 11, 2020

The documentation for these new services is missing. Please create a PR against or documentation to add these services:

https://github.com/home-assistant/home-assistant.io

hudcap added a commit to hudcap/home-assistant.io that referenced this pull request Aug 11, 2020
Adds documentation for services added in home-assistant/core#38749
@hudcap
Copy link
Contributor Author

hudcap commented Aug 12, 2020

Documentation PR: home-assistant/home-assistant.io#14230
I wasn't sure if I should post this as a comment or not...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants