Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quarter-hour period feature for utility_meter component #15290

Closed
wants to merge 522 commits into from
Closed

Add quarter-hour period feature for utility_meter component #15290

wants to merge 522 commits into from

Conversation

thomasdelaet
Copy link
Contributor

@thomasdelaet thomasdelaet commented Oct 17, 2020

Proposed change

In the utility_meter component, add support for 15 minute intervals (quarter-hours).

one (and my :-) use case for this is that in Belgium, a significant part of your electricity bill is going to be based on your peak usage per 15 minute interval. Measuring and managing this peak usage can help to reduce cost.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 17, 2020
@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Oct 17, 2020
@frenck frenck added this to To Do in New documentation via automation Oct 19, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a change pending in the core codebase, thus, depends on the next release of Home Assistant. Therefore, this PR should target the next branch.

Please change the target branch of this PR to next and git rebase this PR onto the next branch if needed.

Thanks 👍

@probot-home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.
(message by DocsTargetBranch)

@frenck frenck removed their assignment Oct 19, 2020
@thomasdelaet thomasdelaet changed the base branch from current to next October 20, 2020 06:43
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch and removed current This PR goes into the current branch in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Oct 20, 2020
@frenck
Copy link
Member

frenck commented Oct 20, 2020

@thomasdelaet You have changed the target, so the thing left to do, it to git rebase your PR onto the next branch.

SeanPM5 and others added 25 commits October 20, 2020 22:40
1. Voice control used to work out of the box, but Conversation integration was removed from default_config over a year ago (home-assistant/core#24515), so these instructions were outdated. Updated the voice command part to clarify this relies on conversation integration being installed too.
2. Cross-linked to the Shopping List Lovelace card page
3. Removed the "click submit" and 'you'll get a success or error' part of instructions as I feel that is very obvious and unnecessary. This makes instructions a bit more concise.
4. Changed "Beer" example to "Milk" to be a tiny bit more kid friendly :)
…es (#14959)

Co-authored-by: Franck Nijhof <git@frenck.dev>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Fixed broken link to troubleshoot section
Co-authored-by: Nader Shenoda <nshenoda@mfganalytic.com>
Old version didn't work, so i asked on Reddit and got an working answer, so here is the change.
Mentioned reddit thread: https://www.reddit.com/r/homeassistant/comments/jce8y2/make_valve_postiotion_its_own_entity/
Co-authored-by: Franck Nijhof <frenck@frenck.dev>
…home-assistant.io into quarter-hour-utility-meter
New documentation automation moved this from To Do to Done Oct 24, 2020
@probot-home-assistant probot-home-assistant bot added Invalid and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo Invalid new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet