Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kmtronic #15953

Merged
merged 7 commits into from Feb 22, 2021
Merged

Add Kmtronic #15953

merged 7 commits into from Feb 22, 2021

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented Dec 18, 2020

Proposed change

Adds the KMTronic integration

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Dec 18, 2020
This was referenced Dec 18, 2020
Merged
Merged
@frenck frenck added this to To Do in New documentation via automation Dec 19, 2020
@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Dec 19, 2020
frenck
frenck requested changes Dec 19, 2020
View reviewed changes
source/_integrations/kmtronic.markdown Outdated Show resolved Hide resolved
source/_integrations/kmtronic.markdown Outdated Show resolved Hide resolved
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Dec 19, 2020
@frenck frenck moved this from To Do to In Progress in New documentation Dec 19, 2020
klaasnicolaas
klaasnicolaas previously approved these changes Dec 20, 2020
View reviewed changes
Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged 👍
⚠️ The ha_release might need an update before merging this one in.

@klaasnicolaas klaasnicolaas added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Dec 20, 2020
@klaasnicolaas klaasnicolaas moved this from In Progress to Awaiting Parent PR in New documentation Dec 20, 2020
frenck
frenck previously approved these changes Dec 21, 2020
View reviewed changes
@bdraco bdraco added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Feb 22, 2021
@dgomes dgomes dismissed stale reviews from frenck and klaasnicolaas via 2370228 February 22, 2021 10:08
@home-assistant home-assistant deleted a comment from homeassistant Feb 22, 2021
frenck
frenck requested changes Feb 22, 2021
View reviewed changes
source/_integrations/kmtronic.markdown Outdated Show resolved Hide resolved
source/_integrations/kmtronic.markdown Outdated Show resolved Hide resolved
dgomes and others added 2 commits February 22, 2021 10:19
@dgomes @frenck
spellcheck
e8f5c3f 
Co-authored-by: Franck Nijhof <frenck@frenck.dev>
@dgomes @frenck
remove header
083dd14 
Co-authored-by: Franck Nijhof <frenck@frenck.dev>
@frenck
Copy link
Member

frenck commented Feb 22, 2021

Thanks, @dgomes 👍

@frenck frenck merged commit ea63201 into home-assistant:next Feb 22, 2021
New documentation automation moved this from Awaiting Parent PR to Done Feb 22, 2021
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Feb 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco left review comments

@frenck frenck frenck approved these changes

@klaasnicolaas klaasnicolaas klaasnicolaas left review comments

Assignees
No one assigned
Labels
cla-signed has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
No open projects
New documentation
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dgomes @frenck @bdraco @klaasnicolaas @homeassistant