Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark about limited featureset on varying MPD implementations #16211

Merged
merged 1 commit into from Jan 17, 2021

Conversation

mweinelt
Copy link
Contributor

Proposed change

Add a remark explaining that different MPD implementations have different featuresets and that the component will fallback gracefully.

This could reduce the confusion displayed in issues like

home-assistant/core#44931
home-assistant/core#44948

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Jan 17, 2021
@frenck frenck added this to Ready for review in Content improvements via automation Jan 17, 2021
source/_integrations/mpd.markdown Outdated Show resolved Hide resolved
@frenck frenck moved this from Ready for review to In progress in Content improvements Jan 17, 2021
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Jan 17, 2021
Content improvements automation moved this from In progress to Reviewer approved Jan 17, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mweinelt 👍

@frenck frenck merged commit b147681 into home-assistant:current Jan 17, 2021
Content improvements automation moved this from Reviewer approved to Done Jan 17, 2021
@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Jan 17, 2021
@mweinelt mweinelt deleted the mpd-features branch January 17, 2021 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants