Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tado.markdown #16287

Closed
wants to merge 89 commits into from
Closed

Update tado.markdown #16287

wants to merge 89 commits into from

Conversation

north3221
Copy link
Contributor

@north3221 north3221 commented Jan 23, 2021

Adding new service tado.set_climate_temperature_offset for pr: home-assistant/core#45014

Also added an example for it

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • [ x] The documentation follows the Home Assistant documentation standards.

mendhak and others added 30 commits January 7, 2021 09:36
Add timestamp to the list of possible sensor_values to be used with update_time entities.
In the HA documentation 'reset_after' is mentioned in the 'invert' description of switches. This should be removed as 'reset_after' is not applicable for HA.
Added Sharp LC-70LE747E to the list
"valve" reflects the VALVE_STATE, e.g. "ADAPTION_DONE" etc.
expand does not work as a filter but only as a function. Adjust the example accordingly.
The part "can view the view tab" was quite confusing here.
- Fixed two spelling mistakes
- Changed casing to match Xbox UI
- Removed extraneous words
…on defaults (#16142)

- Describe how to get to the advanced options.
- Describe the default time for presence detection to mark a device as
away.
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Hmmbob <33529490+hmmbob@users.noreply.github.com>
Co-authored-by: Franck Nijhof <git@frenck.dev>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
I was playing around and saw that Annke and Hikvision have similar software. I tried the component and it worked with my system.
Integration panasonic_viera was removed from legacy discovery in 0.109.6
Co-authored-by: Franck Nijhof <git@frenck.dev>
Removes ambiguity with an Unix/EPOCH timestamp
@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 23, 2021
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Jan 23, 2021
@frenck frenck added this to Ready for review in Content improvements via automation Jan 23, 2021

| Service data attribute | Optional | Description |
| ---------------------- | -------- | ---------------------------------------------------------------------- |
| `entity_id` | no | String, Name of entity e.g., `climate.heating` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is registered using async_register_entity_service, so entity_id became optional.

Suggested change
| `entity_id` | no | String, Name of entity e.g., `climate.heating` |
| `entity_id` | yes | String, Name of entity, e.g., `climate.heating` |

Comment on lines +204 to +207
condition:
- condition: template
value_template: >
{{ (states('sensor.tado_temperature')|float - states('sensor.temp_sensor_room')|float) > 0.5 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the template less long but using multi-line templates? So it comes readable for the user.

@frenck
Copy link
Member

frenck commented Jan 23, 2021

Oh! And this needs to go into the next branch, as it relies on a next release.
Please change the target branch and git rebase if needed.

@north3221 north3221 changed the base branch from current to next January 24, 2021 00:48
@north3221
Copy link
Contributor Author

Oh! And this needs to go into the next branch, as it relies on a next release.
Please change the target branch and git rebase if needed.

Yeah that was an accident cause I didn't know what I was doing. I've changed it but cant figure out how to rebase...

@north3221
Copy link
Contributor Author

Unless I am mistaken you cant rebase on github, so I'll close this PR and raise it again properly

@north3221 north3221 closed this Jan 25, 2021
Content improvements automation moved this from Ready for review to Done Jan 25, 2021
@probot-home-assistant probot-home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Jan 25, 2021
@north3221 north3221 deleted the patch-1 branch January 25, 2021 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet